Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Feb 2022 08:51:05 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     James Clark <james.clark@arm.com>
Cc:     German Gomez <german.gomez@arm.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf tools: apply correct label to user/kernel symbols
 in branch mode
Message-ID: <Yf+2KfqJUdcYlSD3@kernel.org>
References: <20220126105927.3411216-1-german.gomez@arm.com>
 <7474e11b-6bd5-515d-0ebf-883d0656a359@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7474e11b-6bd5-515d-0ebf-883d0656a359@arm.com>
Precedence: bulk

Em Wed, Jan 26, 2022 at 11:27:16AM +0000, James Clark escreveu:
> On 26/01/2022 10:59, German Gomez wrote:
> > @@ -928,7 +928,7 @@ static int hist_entry__sym_to_snprintf(struct hist_entry *he, char *bf,
> >  		struct addr_map_symbol *to = &he->branch_info->to;
> >  
> >  		return _hist_entry__sym_snprintf(&to->ms, to->al_addr,
> > -						 he->level, bf, size, width);
> > +						 to->al_level, bf, size, width);
> >  	}
> >  
> >  	return repsep_snprintf(bf, size, "%-*.*s", width, width, "N/A");
> > 
> 
> Looks good to me, I didn't see any other usages where it could be broken.
> 
> Reviewed-by: James Clark <james.clark@arm.com>


Thanks, applied.

- Arnaldo