Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp202333pxb; Mon, 7 Feb 2022 09:18:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXD46MGkbt+oiCy+9g+BOYkqXgvAk+P9Ike59WXlvbjTe8oDyxL/l52/txFDwp6YcYlXTN X-Received: by 2002:a63:2c46:: with SMTP id s67mr327374pgs.430.1644254317355; Mon, 07 Feb 2022 09:18:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644254317; cv=none; d=google.com; s=arc-20160816; b=mn2s0FCUrFxVl6fUOJPbV7omyKz0sMogSDeUQko30o4acNblbaaVl/dpnBGHGRACpA TtI+V2dHZkNOrRXxOcjXyrfXzZ+oSnL+QrCpsBmO0HT+YAzBEIvV+G4XmbQwigcKxouo p/EHbXE4QSvsshIRLvuqh5FYEcngWa9atkj97iGVeK89hP5kDs5FmX6rFSmnb1fxOpSO c3RbihU5KTe1mhEEzkJYpXLSXbg8XVj9wjUFosZAO2VfKG3Vq8Ig1FrGDkbC4D5rzJ0G q2Z3WyMEUIvS6+j7Vh8nxnzd52NP9GUtfK/p7QkyyvEpVzbg3SZb1XLanFp8s4g9NAU/ FUDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=7YGDXhWoC0YDK4LN4ffYmnnoBIU82UZ+ZgHex0wJpV0=; b=M7Oh1dxr6yCWscQmITTXRE+4DLqcpPVDAAjNx2mCpyZZZcVThPEBp+0LIVIiaPEVvE tMISHtoyxbwyeNoTCbMMKuywJx5lR707ct2Htwr3qmK5j75RRL1581AFDlE+W7FjZKsF JMsbH+pKX34XLPSS6kqzo9xqjDr4svE37PGX9cktxqwh9vz6D8LeYnQ5vcM6FbtfeThX 4JUBurA830sMuSXghEMS6EmB3l9AW8p1zYUgPNWkOBdFocWAfMTFsw7VEBFK7VuLqVk3 FMvz+HJZzjCLDtqMNHi/hrIrTFG3zHsW28QgDRoirjOzkEJLoQBNY0gHIS8zC3hUsHau Mkjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u62si10954716pgd.122.2022.02.07.09.18.24; Mon, 07 Feb 2022 09:18:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378140AbiBEIcH (ORCPT + 99 others); Sat, 5 Feb 2022 03:32:07 -0500 Received: from mail-ua1-f42.google.com ([209.85.222.42]:42618 "EHLO mail-ua1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237940AbiBEIcF (ORCPT ); Sat, 5 Feb 2022 03:32:05 -0500 Received: by mail-ua1-f42.google.com with SMTP id e17so14679911uad.9; Sat, 05 Feb 2022 00:32:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7YGDXhWoC0YDK4LN4ffYmnnoBIU82UZ+ZgHex0wJpV0=; b=UncjMw8rqY4UjHLo07WkzkBdCSnTOrfNQv0PISQI9WHY90YdCZm0595xuRp/8pUT6F Av40KqNEsbtUlDl6jGjXLit0+aDWWCkcpGiuzpP31QQYLfRKbG1mZgkc2JweVviP3m/W Mpn4t5FUv+0uH+lez2d0cJjUF8Z5t9MLIIWj78fhxL0lf07W+1/4lkG0R//umphWYbv5 /FV27L/nm52kX9Ih0PS2vpDUrg5H/gTg378xgKfyTcUksZYw4XNmdFYbKe2fhJ6I95kp igOoT/pKQJEBuY3VCaO3WyoiyNu+os8U8tAxbpiTZwbDR6LXv58+S7mFCxwdGLHbPtmO QMkg== X-Gm-Message-State: AOAM530wLwwginW4T8y4k0zJ3XKIGhx+Mfd0gOVAmcBqtHtxx4xuqnhq TkiW4A4N2urqzacp5v0uOfM1wjy2KElHFQ== X-Received: by 2002:ab0:5a70:: with SMTP id m45mr918793uad.84.1644049924889; Sat, 05 Feb 2022 00:32:04 -0800 (PST) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com. [209.85.222.49]) by smtp.gmail.com with ESMTPSA id 10sm1515017uaq.9.2022.02.05.00.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Feb 2022 00:32:04 -0800 (PST) Received: by mail-ua1-f49.google.com with SMTP id v5so3712575uam.3; Sat, 05 Feb 2022 00:32:04 -0800 (PST) X-Received: by 2002:ab0:384c:: with SMTP id h12mr469698uaw.122.1644049923955; Sat, 05 Feb 2022 00:32:03 -0800 (PST) MIME-Version: 1.0 References: <20220128173006.1713210-1-geert@linux-m68k.org> <63c80eba-7c55-2a92-8078-c63cec3c9efb@gmail.com> <8913a0a2-9496-143c-18c2-f3023fd37ba0@gmail.com> <8d215dab-cd0f-452b-281b-f67c9324b53b@gmail.com> In-Reply-To: <8d215dab-cd0f-452b-281b-f67c9324b53b@gmail.com> From: Geert Uytterhoeven Date: Sat, 5 Feb 2022 09:31:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Regression in 5.17-rc1 on pata-falcon (was: Re: [PATCH] m68k: mm: Remove check for VM_IO to fix deferred I/O) To: Michael Schmitz Cc: linux-m68k , Jens Axboe , Laibin Qiu , Andrew Morton , Linux Kernel Mailing List , linux-block Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Sat, Feb 5, 2022 at 1:04 AM Michael Schmitz wrote: > commit 180dccb0dba4f5e84a4a70c1be1d34cbb6528b32 (blk-mq: fix tag_get > wait task can't be awakened) does cause a regression on my m68k hardware > test rig (m68k Falcon030, IDE disk attached through pata-falcon driver > which does use polled IO instead of interrupts, so may be a little on > the slow side). > Bisection between v5.16 and v5.17-rc1 points to > 180dccb0dba4f5e84a4a70c1be1d34cbb6528b32 as the culprit, which is > corroborated by reverting that commit in v5.17-rc1 and booting as > rapidly as before. Now you know the culprit, it looks like several other people ran into this. Does this fix help? https://lore.kernel.org/all/1643040870.3bwvk3sis4.none@localhost/ It is commit 10825410b956dc1e ("blk-mq: Fix wrong wakeup batch configuration which will cause hang") in v5.17-rc2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds