Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01fee139-873c-347c-b8e4-f6af52dca168@linux.intel.com>
Date:   Sat, 5 Feb 2022 15:10:57 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Cc:     baolu.lu@linux.intel.com, Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        iommu@lists.linux-foundation.org, x86 <x86@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 05/11] iommu/sva: Assign a PASID to mm on PASID
 allocation and free it on mm exit
Content-Language: en-US
To:     Fenghua Yu <fenghua.yu@intel.com>
References: <20220128202905.2274672-1-fenghua.yu@intel.com>
 <20220128202905.2274672-6-fenghua.yu@intel.com>
 <6ace7131-4671-6956-944f-df01e5d63470@linux.intel.com>
 <Yf4Gtm5pu+e2whSE@otcwcpicx3.sc.intel.com>
From:   Lu Baolu <baolu.lu@linux.intel.com>
In-Reply-To: <Yf4Gtm5pu+e2whSE@otcwcpicx3.sc.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/5/22 1:10 PM, Fenghua Yu wrote:
> Hi, Baolu,
> On Sat, Feb 05, 2022 at 11:50:59AM +0800, Lu Baolu wrote:
>> Hi Fenghua,
>>
>> On 2022/1/29 4:28, Fenghua Yu wrote:
>>> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
>>> index 92fea3fbbb11..ef03b2176bbd 100644
>>> --- a/drivers/iommu/intel/iommu.c
>>> +++ b/drivers/iommu/intel/iommu.c
>>> @@ -4781,7 +4781,7 @@ static int aux_domain_add_dev(struct dmar_domain *domain,
>>>    link_failed:
>>>    	spin_unlock_irqrestore(&device_domain_lock, flags);
>>>    	if (list_empty(&domain->subdevices) && domain->default_pasid > 0)
>>> -		ioasid_put(domain->default_pasid);
>>> +		ioasid_free(domain->default_pasid);
>>>    	return ret;
>>>    }
>>> @@ -4811,7 +4811,7 @@ static void aux_domain_remove_dev(struct dmar_domain *domain,
>>>    	spin_unlock_irqrestore(&device_domain_lock, flags);
>>>    	if (list_empty(&domain->subdevices) && domain->default_pasid > 0)
>>> -		ioasid_put(domain->default_pasid);
>>> +		ioasid_free(domain->default_pasid);
>>>    }
>>>    static int prepare_domain_attach_device(struct iommu_domain *domain,
>>
>> The domain->default_pasid is not relevant to SVA and it's being cleaned
>> up by another series. No need to take care of it in this series.
> 
> Because ioasid_put() is renamed to ioasid_free() in this patch, without
> above changes, this series cannot be compiled.
> 
> Thomas and I discussed how to handle aux_domain while you will remove
> the entire aux_domain code (https://lore.kernel.org/lkml/87zgnf29op.ffs@tglx/).
> The above changes are minimal and temporary changes to compile this series.
> The changes will be removed along with the entire aux_domain by your
> removing aux_domain series later in 5.18.

Okay. Make sense to me.

Best regards,
baolu