Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp333505pxb; Mon, 7 Feb 2022 12:29:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPCKHZ7FntHprd3XO0bdpn4gXeXjTOqgMtUGQoOdbbCcPwcxXuo4+tkZQUVNm9huFkyJGT X-Received: by 2002:a63:214f:: with SMTP id s15mr895918pgm.442.1644265749000; Mon, 07 Feb 2022 12:29:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644265748; cv=none; d=google.com; s=arc-20160816; b=eHVkM6KIM+XaT5mZuuoydhZ/EHr3zfdx+R0tmiOgMMd1G+c6SKDIwyYEpWm6rQDpAV hkenaGyh3erVK2Rify5mrLHgRY9uNemdO76YQcy4GUS0a88iKHbsRdylCL1HR8JZLahH XtnCzreoB9Rg8i818Qs9AWpbYRKlAozWbaz3HFNUgaEcsxAvpjGDHY199DN0/qqMn8UL MItPMUNVIyorZLvfuRlnwxC5/gfOjdl165C9QelGJ9mmpyfhvmk7PNb5BoS8TqTLCNEM ps2FGl0TgikZyWXMeWLDvswb3at6L2k3e3ts0R/Jar8ki2Zs8+66wv2XXeQ8rD5mPu0b oUHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=zUqIc3uL7XZcfE1v7zDagl5fTnZ3xDwh4uAORXFN2K0=; b=y/DvJLhXOcCIoewVdI4GCB3SDwyKwPEp53LxKjHQW+p/mEKY2LoMUM0RltDm/NaWs4 Z9/y8ywXwn1vGHVYA8UKa26BPtxYx0Rei0v9dIEFeD4id9cXxD/hImNJek4EiESXcn1O k6SyO5vImKYJ1qWbqLMGzMuZ6cVazzybbR/gWNxkFbPSQAOKWKqUdOOzKi24RVtVYx2p 0ND+ubUHAPAK6G6ml23Y194XMa7lj0Awdj5PVpd8ZsyXH/xXxBVBvsoL+mFWi2OVkREg 2A/YeTw7/z1D3X60mwtThMvRq4yPEjcI6CqadBqQ+JDJ+SYomKWiBxoAu4+QqJhPVoCk RUoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g187si2056956pgc.830.2022.02.07.12.28.56; Mon, 07 Feb 2022 12:29:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348268AbiBFAmN (ORCPT + 99 others); Sat, 5 Feb 2022 19:42:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347637AbiBFAmL (ORCPT ); Sat, 5 Feb 2022 19:42:11 -0500 Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F846C061355 for ; Sat, 5 Feb 2022 16:42:10 -0800 (PST) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 02d5ae26-8538-11ec-ac19-0050568cd888; Thu, 03 Feb 2022 21:26:55 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 1DC39194B78; Thu, 3 Feb 2022 22:25:55 +0100 (CET) Date: Thu, 3 Feb 2022 22:25:52 +0100 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Daniel Vetter Cc: DRI Development , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Du Cheng , Tetsuo Handa , Intel Graphics Development , LKML , Claudio Suarez , Greg Kroah-Hartman , Daniel Vetter , Helge Deller Subject: Re: [PATCH 05/21] fbcon: Introduce wrapper for console->fb_info lookup Message-ID: References: <20220131210552.482606-1-daniel.vetter@ffwll.ch> <20220131210552.482606-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220131210552.482606-6-daniel.vetter@ffwll.ch> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 31, 2022 at 10:05:36PM +0100, Daniel Vetter wrote: > Half of it is protected by console_lock, but the other half is a lot > more awkward: Registration/deregistration of fbdev are serialized, but > we don't really clear out anything in con2fb_map and so there's > potential for use-after free mixups. > > First step is to encapsulate the lookup. > > Signed-off-by: Daniel Vetter > Cc: Helge Deller > Cc: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Tetsuo Handa > Cc: Du Cheng > Cc: Claudio Suarez > Cc: Thomas Zimmermann Acked-by: Sam Ravnborg