Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9a5e9fac-7597-80b6-1cc8-9818b8ff73cd@nvidia.com>
Date:   Sun, 6 Feb 2022 21:19:35 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v4 1/5] mm: Fix invalid page pointer returned with
 FOLL_PIN gups
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        David Hildenbrand <david@redhat.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
References: <20220204020010.68930-1-jhubbard@nvidia.com>
 <20220204020010.68930-2-jhubbard@nvidia.com> <YfzU4Yh/1Oh7Dsw0@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YfzU4Yh/1Oh7Dsw0@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlM4MjErSjM5TmpYOWZ0YzF1RjNSNk5pa0pCbndxOVhoU2VPVkMvTTNhbzEy?=
 =?utf-8?B?OXNSN3BZZVREM1NkY3VoY3h5L2pjL09vMFdjQTJCamVrYXNFWnRrNHZsUUNX?=
 =?utf-8?B?QUVDUElqOEpVQmRpMEJLQzlPbTQwMWlacXBZeGl6V09BbTdzZC9RTFdpNGxz?=
 =?utf-8?B?a2NwNXdZN2Y1L2JWMVA0cmV2MFd4ZTNTNlg3Z2ozNmwvNnk1dFRRWTcxV2VG?=
 =?utf-8?B?TUx3VnY1dDNCc3pFYllMRmhMa1JUQUdLVnRKZmpnRWlPWHFxdndBd2dSdG1o?=
 =?utf-8?B?bUF1cmNwNGUzZm85NjdvOTlQSmxPSjQyYnRxV1pYeTRjUDlHeWhQNDhtcmRD?=
 =?utf-8?B?ZENVMmEzazErblZsZjhxM0hmejJPcmNPZ003cE9vcWorY0Z5YXIzaWNpMkpw?=
 =?utf-8?B?NG5rZ0t6SDk4RXY5dE90WktHOEZQRTlBTkpFU3hoSmZtVzJHc2VieTNaOVpa?=
 =?utf-8?B?TG1LQVN1U01qdm4yNFFVSUhmM2FMVDNyMmp1U2FTU0FINWhscGpSNndTa05o?=
 =?utf-8?B?dHVteEU0VHUzUmlqSWFZY0NTeWtkZDRFcHAyVVhUSGhFcVR5bjRpMU5pelhu?=
 =?utf-8?B?Qzg3ZUd1d2E1dWlQZUhReDlkOTFZaWdZbjdZVlpCN2hZUHVYSHJIcElWVVQ0?=
 =?utf-8?B?cU1veE1ZM0hyZlRwSTlQNE56VDlXVUJSSFF5ejlpRHlxejdCTS9SRUM2M2d3?=
 =?utf-8?B?MFlnUGh4NVJuSGJrNGN5c01kVFZnbDdOWjFGeGs2UGNOdkx3OVpvbVlFTTQz?=
 =?utf-8?B?MC9vMEpwbXVFdUFoVU5VbzVxWC9xcE5PNkZTUEJJQUlFMnA5NmMxQ2pETTd2?=
 =?utf-8?B?d21wYldpUUk1Vi9ib29CSFFkT2Q1ZE5rRG1kS0RpWGlVcGRad1NjdG9BRS9p?=
 =?utf-8?B?SzVzYlZtQ0FoZEhVZXhrY2ZJY0ZVeG5mQjlyenoyMGh5dFFrK3lLMDdha1l0?=
 =?utf-8?B?SkVxUzRIMDVpUTRoMzNTUERQdVdGTExPTDJCc1RMaXk0YkV3N1VIZ1dBclcv?=
 =?utf-8?B?SUpDWE1wTVJRYTdFeXAyekRJQlhDWnFNbHNBNnN6dHg2SWxNOERWU1JjdjNu?=
 =?utf-8?B?TVpOYTRWUUg1RUVTYjhXVzdRZDlVSWtWYmN6SUxqeEptNkVMSC91V3h4NkY4?=
 =?utf-8?B?dEFzWVV4N2lnTnR4dlUram85bG4zclhjdzJ3YTJaeTM1UzZzWDFVZHVTTWM1?=
 =?utf-8?B?eXVyeTU5eHYxb2tBY1k2enNwYmoyaG4reFpyRmhuZVlIMTNROC9TS25naWlK?=
 =?utf-8?B?YUM2MlZWVzFGOVdlWjhGTWljVlF2OU41UC9xUXpYeW1sT241bUVJcFlGc0Yw?=
 =?utf-8?B?UnFYWHUxeGEyTzJ3eFVSbVpKSmxJRVQrWUs3RVlKTjdFUnVrTjk1L0dyd1NM?=
 =?utf-8?B?NlBzUFJXMDB5d1JXbjJpck9DWnFuY1Job3NSeWVHVVZTTlpyWDNpSWIvYjBF?=
 =?utf-8?B?ZExJN3ByVXgvcUNaSjhVTG9VZ3ljT3JjVlEwblZoSXFuOHVhNXhGL3FVNVNq?=
 =?utf-8?B?N2FhbXBtcDlLcW5rc2k4TlJCMGEzMXZiSG43SUc2S0c1NkVMczFHVGdVUU1V?=
 =?utf-8?B?Y1U2VDRjdHRZNDhCSVdrM2tuUFJNdy9sS3IvSmVRS0xiRFRRNjRPemFWYmhO?=
 =?utf-8?B?aE1GM3VCb3VPYkZ0V1dXMjU5eng3TUpzeEMvdklwdFYvWWlubHgwK3BCV3dq?=
 =?utf-8?B?d081L3EwOVRjSnc2czFqcmZLN3VsMkJlVGJ5WnRRbVM1R0p4aWRyL1dEZi9B?=
 =?utf-8?B?cXZzeHFMYndIQnIwdXVlRUVOQ3cyR3VqM0JqQ3JhZUxFa3RyZVozejZhdlBW?=
 =?utf-8?B?aDVIWW1xV01acGh6Z0lnZHJVbmFGNTBGYUtYSUthY0V4VnVXdVFhaktmRHRy?=
 =?utf-8?B?M01QRWI1a2tuWXVjWkp0RHZKV2RsMDNvbzUrc2F4VUJ1cDZpelU1T1NsSCs4?=
 =?utf-8?B?clNpRmI1TVNCMHFlOE9rVlFUdDdUS0FLWnh3WEFZOFNqcktOaS9BdXEzOXA1?=
 =?utf-8?B?VWxxMnVuWFk3bGFqUWVDY1R0b1hnU2t3REpRT3ZzOXBSS1JPa0xYUkIzaTNW?=
 =?utf-8?B?WXovOGZjU21yR1FYQ1ROMHZ1MGFOZ0EvL2MxblMrQnM3MFBjclNLbmx6NnRG?=
 =?utf-8?B?b1pCdTJFWDF0aHFWRWU3dEp1MXdYNS9sRkExREZyT2xDUkp5Zy96ajU0dFRW?=
 =?utf-8?Q?ZOr79H601wh3/UmaZzOZy/E=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f168f77-ad5d-4683-9375-08d9e9f96f49
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 05:19:37.4263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2Fh6YQs2RxKdT6zigpr9ksxE6oYYjogi139Ilf7nFczeocq3GtXKiNwc8bmh66nKBFMO4YxttuCXhbp2jfp6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5601
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/3/22 23:25, Christoph Hellwig wrote:
> On Thu, Feb 03, 2022 at 06:00:06PM -0800, John Hubbard wrote:
>> From: Peter Xu <peterx@redhat.com>
>>
>> Alex reported invalid page pointer returned with pin_user_pages_remote() from
>> vfio after upstream commit 4b6c33b32296 ("vfio/type1: Prepare for batched
>> pinning with struct vfio_batch").
> 
> This commit message uses overly long lines all over.

I'll reflow it to 72 columns and post a v5 with the full set of
reviewed-by tags.

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

I appreciate the reviews, from you and everyone, as always.


thanks,
-- 
John Hubbard
NVIDIA