Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp526395pxb; Mon, 7 Feb 2022 17:50:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGkbjOcIsFkNdKsynp7aIc0629+ei3juAUVxF+C6W5e7SrsDvvzev8nN9p3OMe7u40hdKZ X-Received: by 2002:a05:6402:1d8b:: with SMTP id dk11mr2279103edb.246.1644285000662; Mon, 07 Feb 2022 17:50:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644285000; cv=none; d=google.com; s=arc-20160816; b=FEYgxHDNyvwAbUNanhw5VPWrogkgEWqXoQKdWfydbNA9awwqRaCIZcRVJ5aFFlgm6k YHXda7vJh+GwZMKII66ogPWErBZvNJlt/7mUOewKUwHlX5YfqaUs5/eKp6YjeEG5EoEq idu8AoyDgcm0ld8SaajhATWlZmrOqnWWwKCy6Vauy4LpBez0iL/vHQ+YZCNUXyPrekkT HQ6LgA9TCXZW9Tx2DRj/EL+97lQn/E3jW8aYT9LbixDqz54yuXF72pHQwMVP0BtXQ6MW X8JKkvsxUiXrgdoohZq/yH1Tlhzd6bAF2uqIs9IctbGgqcFZkEFKOWFa3oRPhzm3mMec VC7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=c3UO1TTRZqzSjjDQY9Mwanici3NZ8tfp3AuhU7oMYuA=; b=EGrJfXQ9QrDd1KB1lbH7o2ggKTdFay/Pd+HG0RtdCr7IPa4rL7pUeklzJYw6S6n/g9 gZ/XdBNK0ql7MM1wOGcqLF4gMwIrJ63jzwnBkl8zO3aeaQMYmNymgvlj48b9JudsEahR Qu0lrtbEo+RBaLwWPM4XcZO1sHpagsOmPrpZVfCV752L526Y3D0/zwDmNZWJh1f/a1Qj x47w7MoYBn7JayzY/q8/7ZzfEPlgjSPRTnuYjVIXAB055WwE0VUrjXX/qDK+xU0ODArJ 2yV+d0+V/87LqltwYQCp9xcfDaJpmkvPYNAu6jYkAgBoleoYle4bxfdJhdKh9QbLphT9 dHfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20210112.gappssmtp.com header.s=20210112 header.b=QPHaqlTi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v27si2788882ejf.815.2022.02.07.17.49.36; Mon, 07 Feb 2022 17:50:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20210112.gappssmtp.com header.s=20210112 header.b=QPHaqlTi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379248AbiBGRcm (ORCPT + 99 others); Mon, 7 Feb 2022 12:32:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242434AbiBGRaw (ORCPT ); Mon, 7 Feb 2022 12:30:52 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6D7BC0401DC for ; Mon, 7 Feb 2022 09:30:51 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id v5-20020a17090a4ec500b001b8b702df57so3871004pjl.2 for ; Mon, 07 Feb 2022 09:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c3UO1TTRZqzSjjDQY9Mwanici3NZ8tfp3AuhU7oMYuA=; b=QPHaqlTiE16WocBPSKB+Lh+Ski0qtk/u+htUzq292AHwqkwfgCqNFPoyzWnzp35sr1 n78XPElUsjVk+gUGFqDap1fb/7cK7w3cKnLfv/E1GfzCkSjYiGDbS4+eZ00YZIqec36r 55RYOC2HtBq5z7nfTlvxbqnm0+1d/78bCDNOvtUD+Jznz0Pv/3oQaLKY4fJGfaDokHcs m3OPmlwR+CTgXREhrBYj5yishPrXwWxcJrEjBiv+ALyN8E2AYBv2GcZorbFEj/MBHjdb i4HFCxGCYrfT39BP2j5Ag0bTWXBwepHMjSv7tZCU5oF3rdb1QaapZIZPlDDy/uKn9Kx/ hOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c3UO1TTRZqzSjjDQY9Mwanici3NZ8tfp3AuhU7oMYuA=; b=DmgMwBU01aXvfTwZrVXG6+kGBjaMrhV4RXcMNT94HKb7CyCKQ+TJD+R38jyd4bmYBk tfFbDeeWdvwUEco6qTx1he//de2dZsb9ViQrppJXm6YafVGcR2R/TGQPbJDniNQxrCPn RSSR6gA/uzcaqOpuboIqAftwaQoxeE7wVO5TQ7yH33Gv/Y5aOcZOA54etHUSktl+MxvG 8kQNrRz1QplUkLcnI/ps41jpR71TAo99y9rjAfiC8tdT6+WIDFnTpI+dO2t9pxMeDYoK BDOlFStwZc/f2aEhZexqCSBM/NozYz32qlLi5vR6Itry27m0OJ6vUoYs4b6CgQw+zDlu iArw== X-Gm-Message-State: AOAM532PCYzq1XkfPldhkks4NdfM6Rp+rJpv8WNmdKnVsIsWJXv2idE8 N/xdIFIxY9hz5KS/2GaecTncJA== X-Received: by 2002:a17:90a:af97:: with SMTP id w23mr11768861pjq.162.1644255051050; Mon, 07 Feb 2022 09:30:51 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 38sm8878921pgm.37.2022.02.07.09.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 09:30:50 -0800 (PST) Date: Mon, 7 Feb 2022 09:30:48 -0800 From: Stephen Hemminger To: Hans Schultz Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Hans Schultz , Roopa Prabhu , Nikolay Aleksandrov , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next 1/4] net: bridge: Add support for bridge port in locked mode Message-ID: <20220207093048.24bb6249@hermes.local> In-Reply-To: <20220207100742.15087-2-schultz.hans+netdev@gmail.com> References: <20220207100742.15087-1-schultz.hans+netdev@gmail.com> <20220207100742.15087-2-schultz.hans+netdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Feb 2022 11:07:39 +0100 Hans Schultz wrote: > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -532,6 +532,7 @@ enum { > IFLA_BRPORT_GROUP_FWD_MASK, > IFLA_BRPORT_NEIGH_SUPPRESS, > IFLA_BRPORT_ISOLATED, > + IFLA_BRPORT_LOCKED, > IFLA_BRPORT_BACKUP_PORT, > IFLA_BRPORT_MRP_RING_OPEN, Adding new element in middle of enum causes them to be renumbered. That breaks the kernel ABI. Please add only at end.