Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e59fce3747428f30afdf77f9839910664e3e8524.camel@gmail.com>
Subject: Re: [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc:     jic23@kernel.org, robh+dt@kernel.org, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 07 Feb 2022 21:29:54 +0100
In-Reply-To: <Yf7AjXsRuhFeFTpD@smile.fi.intel.com>
References: <20220131100102.15372-1-antoniu.miclaus@analog.com>
         <Yf7AjXsRuhFeFTpD@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2022-02-05 at 20:23 +0200, Andy Shevchenko wrote:
> On Mon, Jan 31, 2022 at 12:00:59PM +0200, Antoniu Miclaus wrote:
> > The ADMV1014 is a silicon germanium (SiGe), wideband,
> > microwave downconverter optimized for point to point microwave
> > radio designs operating in the 24 GHz to 44 GHz frequency range.
> 
> Excellent job!
> A few comments / questions below.
> 
> ...
> 
> > +config ADMV1014
> > +       tristate "Analog Devices ADMV1014 Microwave Downconverter"
> > +       depends on SPI && COMMON_CLK && 64BIT
> 
> Why 64BIT only?
> 

Could not resist on this one... The thing is that CCF uses unsigned
long for rates and this part operates in high GHz values. That means,
as CCF stands, this cannot work on 32bit.

- Nuno Sá