Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Gwendal Grignou <gwendal@chromium.org>
Cc:     dlunev@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "fat: add simple validation for directory inode"
References: <20220204062232.3410036-1-gwendal@chromium.org>
Date:   Sat, 05 Feb 2022 15:21:15 +0900
In-Reply-To: <20220204062232.3410036-1-gwendal@chromium.org> (Gwendal
        Grignou's message of "Thu, 3 Feb 2022 22:22:32 -0800")
Message-ID: <8735kxx290.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Gwendal Grignou <gwendal@chromium.org> writes:

> This reverts commit a3082d526f2d406d4b488e49a508a0062a23314f.
>
> The reverted commit adds check for FAT images. However, the tools used
> for creating images for the Lego Mindstrom EV3 are not adding '.' and
> '..' entry in the 'Projects' directory.
> Without this fix, the kernel can not fill the inode structure for
> 'Projects' directory.
>
> See https://github.com/microsoft/pxt-ev3/issues/980
> And https://github.com/microsoft/uf2-linux/issues/6

Looks like the bug of those tools. If you want to add the workaround for
those tools, it should not break sane format.

I.e. the workaround should at least set the directory link count to work
rmdir(2) without warnings, then should test other operations if works
well.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>