Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp635415pxb; Mon, 7 Feb 2022 21:39:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBAnz6jNPYxf3PAwdjIK/f43GkKfKIRI9hGQsvJrU2mgd6BvZN2b9o8Vsfvu70u2voR+Yx X-Received: by 2002:a17:90a:f28e:: with SMTP id fs14mr2668471pjb.26.1644298756998; Mon, 07 Feb 2022 21:39:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644298756; cv=none; d=google.com; s=arc-20160816; b=CPPnFMzRt9KnIqr3n/zw9MNxnwIOJDU9RgCiTqtBVzdbSAGwFrhdBRjbR2vDtkX0Y5 exU6fHbcurhtTKRAgvLsCbJ91Ntz16O97np6sAobEsev6H7/tV8RNJwO7y07bfe6eukj wnd427kBH+gBDLmqMSoiZBd42YDS8NlGQ5aqATxDjB82URGmyrNqX6Cr4mHoe5tp/7mN sR181ynDpUFP4jFYP5wm5+f1yun2d1O47Pl6NqS+1YWFC8R62EE3yMd1lKsnTN8tys2e oV9wBBG9xLwiGogL3Sl1TEN5ns2Zyrh7LgHNszfqzTDiMVhpSLLBMuAYBDCAVthPkMhE 0sgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aCZXhcVXSPv1P9tobnQfMHdpYQnynrNHE8D3Hvg84Ro=; b=PIMeeel9AMZhgmAKZE9uC3keUF/L0uogeWICyKVGlfhmDJPUW3BmZs+jN+Dy86dNdW +38KN9Am2OTPrAu56n8OJzaKdUJoKyHV/auFgWlhyN0e9LozvkxiZTAtOqpv08w60UdU O6e5cLWW0yHOanDwLz3IjVMnfp48a7IB2MWGrigL56NGOVTi0y+p97xbm+ZilvF00WV3 GmkL1Y/Z3jkwZnqyXI7IsjXpniKPiB1QJeluFYui1DJj73ChDhgCuR0QtdCZNP8ouSuf fbF9rFeALhHwJy0VwRtHhOjHSbqGfkb/I2dByVHyMtr97SX4qX0nlYx4yUYF65/EUOVv ZSJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=g3HAMExK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e186si12619598pgc.200.2022.02.07.21.39.01; Mon, 07 Feb 2022 21:39:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=g3HAMExK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383178AbiBGOoS (ORCPT + 99 others); Mon, 7 Feb 2022 09:44:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1441837AbiBGOd1 (ORCPT ); Mon, 7 Feb 2022 09:33:27 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DCAC0401C1; Mon, 7 Feb 2022 06:33:26 -0800 (PST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 217DnQIs003511; Mon, 7 Feb 2022 14:33:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=aCZXhcVXSPv1P9tobnQfMHdpYQnynrNHE8D3Hvg84Ro=; b=g3HAMExKodEqeYA8+lS83FmnojJ+UJSRrEQAw7jOPxg2B2sKuzdRV/xrpHilZJ7BNUzT egz22dE3KNQjC0j2L3AqGH8Bhgnq0ywC6ni1IcriwNhbNVjKBC/qLBOhEQrmBBCsOV8Z RdYovBpqsp8hDsYiwGMZWatvYH4zkOy9FtPps4CDR2k1lqCBttxoZR7bfIMWm3Ag9U58 L2XhoxY8VSP7YCw7JniWFqUDByKdYyv2Yxaxf8dkXWgsfciVA4RaoWY2QUeV8mSiCj+o 33xOXaWrG7gamLYUShgkWuWf7ejYoDlWre2nAfoEg37fJ2EpcJ/E2lXX25ww7co3HdzV EQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e22qep77g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 14:33:26 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 217ETKgb007027; Mon, 7 Feb 2022 14:33:26 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e22qep76g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 14:33:25 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 217EW9kw000827; Mon, 7 Feb 2022 14:33:23 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma03fra.de.ibm.com with ESMTP id 3e1gv94w08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 14:33:23 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 217EXHt923921000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Feb 2022 14:33:17 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 58FFB52057; Mon, 7 Feb 2022 14:33:17 +0000 (GMT) Received: from osiris (unknown [9.145.87.217]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id E60A452050; Mon, 7 Feb 2022 14:33:16 +0000 (GMT) Date: Mon, 7 Feb 2022 15:33:15 +0100 From: Heiko Carstens To: Janosch Frank Cc: Claudio Imbrenda , kvm@vger.kernel.org, borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.ibm.com, david@redhat.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, scgl@linux.ibm.com Subject: Re: [PATCH v7 01/17] KVM: s390: pv: leak the topmost page table when destroy fails Message-ID: References: <20220204155349.63238-1-imbrenda@linux.ibm.com> <20220204155349.63238-2-imbrenda@linux.ibm.com> <0939aac3-9427-ed04-17e4-3c1e4195d509@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0939aac3-9427-ed04-17e4-3c1e4195d509@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 9ET2utHlInBuupsodJsb4ISe87Ns56WD X-Proofpoint-GUID: fC4jLNtkByYpueAS_0s5-3sGam0RN0AG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0 clxscore=1011 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0 mlxlogscore=991 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202070093 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + asce = (gmap->asce & ~PAGE_MASK) | __pa(table); > > Please add a comment: > Set the new table origin while preserving ASCE control bits like table type > and length. And while touching this anyway, please make use of _ASCE_ORIGIN instead of PAGE_MASK.