Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbXBKDtU (ORCPT ); Sat, 10 Feb 2007 22:49:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752647AbXBKDtU (ORCPT ); Sat, 10 Feb 2007 22:49:20 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:55925 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbXBKDtT (ORCPT ); Sat, 10 Feb 2007 22:49:19 -0500 Date: Sun, 11 Feb 2007 03:49:02 +0000 From: Christoph Hellwig To: Heiko Carstens Cc: Andrew Morton , Linus Torvalds , Martin Schwidefsky , Jeff Garzik , Tejun Heo , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [patch] linux/io.h: forward declare struct pci_dev Message-ID: <20070211034902.GA9077@infradead.org> Mail-Followup-To: Christoph Hellwig , Heiko Carstens , Andrew Morton , Linus Torvalds , Martin Schwidefsky , Jeff Garzik , Tejun Heo , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org References: <20070210114550.GC12642@osiris.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070210114550.GC12642@osiris.boeblingen.de.ibm.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 43 On Sat, Feb 10, 2007 at 12:45:50PM +0100, Heiko Carstens wrote: > From: Heiko Carstens > > 9ac7849e35f705830f7b016ff272b0ff1f7ff759 causes this: > > CC arch/s390/mm/ioremap.o > In file included from arch/s390/mm/ioremap.c:18: > include/linux/io.h:46: > warning: "struct pci_dev" declared inside parameter list > include/linux/io.h:46: > warning: its scope is only this definition or declaration, > which is probably not what you want > > Guess it's time to get rid of ioremap.c on s390 if possible... > > Cc: Tejun Heo > Cc: Jeff Garzik > Cc: Martin Schwidefsky > Signed-off-by: Heiko Carstens > --- > include/linux/io.h | 1 + > 1 files changed, 1 insertion(+) > > Index: linux-2.6/include/linux/io.h > =================================================================== > --- linux-2.6.orig/include/linux/io.h > +++ linux-2.6/include/linux/io.h > @@ -22,6 +22,7 @@ > #include > #include > > +struct pci_dev; > struct device; I haven't looked at what causes it, but any leakage of pci details into io.h is bogus. I'd suggest that the original submitter fixes up that problem instead. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/