Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Feb 2022 09:43:31 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Joseph CHAMG <josright123@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>, joseph_chang@davicom.com.tw,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
        andrew@lunn.ch, leon@kernel.org
Subject: Re: [PATCH v18, 2/2] net: Add dm9051 driver
Message-ID: <20220207094331.6c02c521@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20220207090906.11156-3-josright123@gmail.com>
References: <20220207090906.11156-1-josright123@gmail.com>
        <20220207090906.11156-3-josright123@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon,  7 Feb 2022 17:09:06 +0800 Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work for the
> device platform which has the spi master
>=20
> Signed-off-by: Joseph CHAMG <josright123@gmail.com>

In file included from include/linux/etherdevice.h:21,
                 from drivers/net/ethernet/davicom/dm9051.c:7:
drivers/net/ethernet/davicom/dm9051.c: In function =E2=80=98dm9051_rxctl_de=
lay=E2=80=99:
drivers/net/ethernet/davicom/dm9051.c:930:42: warning: format =E2=80=98%d=
=E2=80=99 expects argument of type =E2=80=98int=E2=80=99, but argument 6 ha=
s type =E2=80=98long unsigned int=E2=80=99 [-Wformat=3D]
  930 |                 netif_err(db, drv, ndev, "%s: error %d bulk writing=
 reg %02x, len %d\n",
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~=
~~~~~~~~~~~~~~~~~~~~
  931 |                           __func__, result, DM9051_PAR, sizeof(ndev=
->dev_addr));
      |                                                         ~~~~~~~~~~~=
~~~~~~~~~~~
      |                                                         |
      |                                                         long unsign=
ed int
include/linux/netdevice.h:5107:37: note: in definition of macro =E2=80=98ne=
tif_level=E2=80=99
 5107 |                 netdev_##level(dev, fmt, ##args);               \
      |                                     ^~~
drivers/net/ethernet/davicom/dm9051.c:930:17: note: in expansion of macro =
=E2=80=98netif_err=E2=80=99
  930 |                 netif_err(db, drv, ndev, "%s: error %d bulk writing=
 reg %02x, len %d\n",
      |                 ^~~~~~~~~
drivers/net/ethernet/davicom/dm9051.c:930:84: note: format string is define=
d here
  930 |                 netif_err(db, drv, ndev, "%s: error %d bulk writing=
 reg %02x, len %d\n",
      |                                                                    =
               ~^
      |                                                                    =
                |
      |                                                                    =
                int
      |                                                                    =
               %ld