Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Feb 2022 12:21:21 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Tyrone Ting <warp5tw@gmail.com>
Cc:     avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com,
        venture@google.com, yuenn@google.com, benjaminfair@google.com,
        robh+dt@kernel.org, krzysztof.kozlowski@canonical.com,
        semen.protsenko@linaro.org, yangyicong@hisilicon.com,
        wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev,
        bence98@sch.bme.hu, lukas.bulwahn@gmail.com, arnd@arndb.de,
        olof@lixom.net, andriy.shevchenko@linux.intel.com,
        tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com,
        tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
        kfting@nuvoton.com, devicetree@vger.kernel.org,
        openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/6] dt-bindings: i2c: npcm: support NPCM845
Message-ID: <YgEAsTW6DrZSSgL+@latitude>
References: <20220207063338.6570-1-warp5tw@gmail.com>
 <20220207063338.6570-2-warp5tw@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NaN2xgGUpssnCj8u"
Content-Disposition: inline
In-Reply-To: <20220207063338.6570-2-warp5tw@gmail.com>
Precedence: bulk


--NaN2xgGUpssnCj8u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Feb 07, 2022 at 02:33:33PM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <kfting@nuvoton.com>
>=20
> This commit adds compatible and syscon description for NPCM845 i2c module.
>=20
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller drive=
r")
> Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> Signed-off-by: Tali Perry <tali.perry1@gmail.com>
> ---
[...]
> =20
> +  syscon:
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
> +    description: The phandle of system manager register node.
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
>    - clocks
> +  - syscon

By making the syscon property required, the existing npcm7xx devicetrees
become wrong (because they don't have the syscon property).
Please, either keep it optional, or adjust the npcm7xx devicetrees in
this series.


Best regards,
Jonathan

--NaN2xgGUpssnCj8u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmIBAIsACgkQCDBEmo7z
X9sN+hAAxwYehg8JfvdijxWJEGC9oYMzKVhAiQcyLJQUFWyKpIj9X8UVhwdUvDdp
zFzr/+Q9H0xFTRvJuRY6L0j2BpoQcmEu6TmqC4UVeElY6aJkxtBhtwGogdNI7ZRz
9xw8BEAypsCh2Aqx1RWI8M9uvfVov/6PuSVFmowTiL+D/j5SzhZPC4F2aK7iMucs
3VEpS9mTwS01TR3U6afuHjUfeqPW9SgORy776khM8gM61mvku0dfnE+YTlvuT8nB
Yj7kNvFqjSz0h2ETItDdERXycwEijVOpOK7yst6Eh2POE/A+u3TTgC8hUjkjwmsM
r8Tii/9ssnpEsG8u/vUPPdzSiqq1Xlte7cnaex0EZvQSQ6J/FEZQtdeN975BMg8n
W0RvAFE0+sZ0su+olsShCg9LXvtlU7mHuJtnd6Rqc9LpQHXhzPqtaUCn0c+S7p4E
3HPTdtN92zbSdQ0S37Wb4BtDPSzFwekYd2NUSozdRclT9Vm9r/XJwyI8C+suRuTN
8fihbstXrryOHpMsy2DReOlJ31K4RhSorgzTHJAyTo5mMCnS9uLxlhqZDDNGwvl+
Jh1n96uAETIeqFT9G7IW6VY+ntvP9ekKlu+FiQpu56DK+NmF0fxeTJusMr2AvMzH
j+kI/tULDt8ZfX4lmfqt6BSPwlGuG0APBkYwJPRJ4IRPjYv03uM=
=auDF
-----END PGP SIGNATURE-----

--NaN2xgGUpssnCj8u--