Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Krishna Yarlagadda <kyarlagadda@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: RE: [PATCH 6/6] spi: tegra210-quad: combined sequence mode
Thread-Topic: [PATCH 6/6] spi: tegra210-quad: combined sequence mode
Thread-Index: AQHYGbI5hON+MFM3SE2C51fYICcN6ayDbjeAgATDdiCAAAM7AIAACcCg
Date:   Mon, 7 Feb 2022 15:40:26 +0000
Message-ID: <DM6PR12MB35630E186CE9507BFF620840C32C9@DM6PR12MB3563.namprd12.prod.outlook.com>
References: <1643970576-31503-1-git-send-email-kyarlagadda@nvidia.com>
 <1643970576-31503-7-git-send-email-kyarlagadda@nvidia.com>
 <Yf0zkdS2nqHOZjMG@sirena.org.uk>
 <DM6PR12MB35630A9020EC4B309D877086C32C9@DM6PR12MB3563.namprd12.prod.outlook.com>
 <YgE1PD2irQeinD9N@sirena.org.uk>
In-Reply-To: <YgE1PD2irQeinD9N@sirena.org.uk>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wsrw8mgx3xat5PADQRgFkUzGctpejNeDAuW00pDWav0kZAObOKbzqojDgUhY?=
 =?us-ascii?Q?fr9EnwDI9A5bTMphMVSjUbUj5TsOPuw1tPfjeQaG2vbWyLoRCACweAv9zn8R?=
 =?us-ascii?Q?94OKKLcjgI+3LjcQkIovihtv0aRmMBM1a0VOzOKtdpnLK7Ivk+T4YyCAAUBa?=
 =?us-ascii?Q?vdKi3QUd/CJbZ0ZViCOvaZ/j5q/NPjeyB7KajhC6RgWw9bL6xtfdsUzJGxUh?=
 =?us-ascii?Q?eNSke0MeL30GpAprNbFGAxiCuNZf0/uMDzYlNsGWFwBNdUiBPEWOlKcwbvZF?=
 =?us-ascii?Q?hsKRakPionDFl9S0pWR451Bcep0CXbvlbKBOaucMb9NiWchG6ZCyh+R3S0fG?=
 =?us-ascii?Q?1Du5VM3aGpeSgfULazZI8Cfc2ig2CzB/UD5XYPuJ9pqCvsJDBLf+YeTWjOuo?=
 =?us-ascii?Q?RiSNEILxHlTcq2arJaKBKTRp7eZzV7vfKP6ddpdK2AClIv3b9Z45nN9aoHKS?=
 =?us-ascii?Q?o7NZAmB2qKRFOcx9E/XbIgCFYE1lfnkstXJ92NYR2VmzQf/OPca/AKzdPfak?=
 =?us-ascii?Q?2AEgaLDIXkWj6/Gbn7BRMJUhDprGdzi7VeJ3ZSlT6nJoM/XlkyICkK/QRg6G?=
 =?us-ascii?Q?sbTZvVIvS7eqbZ0+3pjwWDsLqmQyXUHi7/mVtUr6F5TUS0/ROBwnTa+QA0WG?=
 =?us-ascii?Q?y9E0d5a+TzyHvMwniyJVvpTQB49n5/F2GtTlc6fvQccK0Qpl+wPbQAhq9L0K?=
 =?us-ascii?Q?DDJUgXAJOgf705mR+rTdh7jJISFzU4v1D+OTRfF9vwCA+GKX3ehF5XP1RIKl?=
 =?us-ascii?Q?x9QS2CppwMv6AA7lE7EJK68+3yAbmhSS7C6A4izfUjoY7E62DkaR9y3XApnc?=
 =?us-ascii?Q?IKrhIIUnhIkW+hYr74ApAWzHnqfA5paC/bNsEHIZY7bBSwxIyHsZkGwNlHRs?=
 =?us-ascii?Q?8WNySDHSGqBimtF/ApprmndK0BwISc0SYO4K8jvUI6IPod1GU2NH4FtT/Tlw?=
 =?us-ascii?Q?SANKpbXaXMoq02LITQ0gHqDdCVa/CMG5alvDbQbVYVn+SWq4++DhNlBjkH3l?=
 =?us-ascii?Q?EQWNVQSF9tToJ3wCjn4/x3Y4yowoV93EeqoXqfpUYK5VOtx8eLJzQb+eCvVq?=
 =?us-ascii?Q?QqQJivFo7bfsgBwLvoiJJSRW80zFDKaBnnejPvdLp/FUqjln3dEWqlLLSqhI?=
 =?us-ascii?Q?v2lgadlUHQ6jKZ+JNIAyoqjMAm6PTC4iQ3N9W8LMCdN8rkmrCcy63Lo0dY+t?=
 =?us-ascii?Q?2BkZ6vGkh9sPyFJq3+lrzTnpErgF9TN6De3fl5S4VyZ7TSwjhsEKO+zM64IF?=
 =?us-ascii?Q?xqOhcrQhcKmKk6Nhg2ZSczi7qjIl0HHoV47R78DBZqKeVYVB31rWvOTN66Rq?=
 =?us-ascii?Q?g/9e33kH8JFXHMJp0/e/xEwJhIZHDXmrN38J5esM8+YgagyQKWiBVUsjiYBw?=
 =?us-ascii?Q?C+wEcs4zIlbiQyzWYOiR7tJ6SOdv8JNdxteJ9Rf9gRd6iduHLHlsHa1Z7Ow6?=
 =?us-ascii?Q?hrZCVDjJJJd1mW57a+qD+YMX1xkGnbYGvwjxxWbdDlw/pXAgMhDXKdQpZ3cl?=
 =?us-ascii?Q?PiTnkMD6xGMQ9QWeht4pCk70SPFpaAM0W1UKNKy0Iy+OrV8wBme9wtzLhpES?=
 =?us-ascii?Q?DpECyvNckcEsbJBrSylFh8E/2A0+Rd/ilXmn2VYyza2Fl67oskEmeM9Z4b5U?=
 =?us-ascii?Q?+fgQFtvQLZXoS0b2X5bxOa4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3563.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1214dc77-1e1e-429e-81e0-08d9ea5029e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 15:40:26.9782
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gUQsH+bfKGmW8iB84ULbJnXF0ibfZXBttwsojf20DpEGx+xP8off/t/fWrODJBldVaeXaWbnqWrLX7SXbODYLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4178
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 07 February 2022 20:36
> To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> Cc: thierry.reding@gmail.com; Jonathan Hunter <jonathanh@nvidia.com>;
> linux-spi@vger.kernel.org; linux-tegra@vger.kernel.org; Sowjanya
> Komatineni <skomatineni@nvidia.com>; Laxman Dewangan
> <ldewangan@nvidia.com>; robh+dt@kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> p.zabel@pengutronix.de
> Subject: Re: [PATCH 6/6] spi: tegra210-quad: combined sequence mode
>=20
> On Mon, Feb 07, 2022 at 02:54:00PM +0000, Krishna Yarlagadda wrote:
>=20
> > > > +	if (cdata->is_cmb_xfer && transfer_count =3D=3D 3)
> > > > +		ret =3D tegra_qspi_combined_seq_xfer(tqspi, msg);
> > > > +	else
> > > > +		ret =3D tegra_qspi_non_combined_seq_xfer(tqspi, msg);
>=20
> > > This check needs to be more specific.  But like I said in reply to
> > > the binding patch I don't see why we can't just pattern match on the
> > > data without requiring a property here, we'd need to check that the
> > > message is suitable no matter what.
>=20
> > There is no real-world use case we encountered so far preventing us sti=
ck
> to pattern.
> > But this was to avoid any corner case where there could be 3 different
> transfers sent in single msg.
>=20
> So you'll remove the property and just pattern match on the message?
Yes. I will send out V2 without property.
>=20
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.
Sorry. Fixed mail client now.