Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Feb 2022 09:43:01 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     menglong8.dong@gmail.com
Cc:     kuba@kernel.org, dsahern@kernel.org, idosch@idosch.org,
        nhorman@tuxdriver.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH v6 net-next] net: drop_monitor: support drop reason
Message-ID: <20220207094301.5c061d23@gandalf.local.home>
In-Reply-To: <20220205081738.565394-1-imagedong@tencent.com>
References: <20220205081738.565394-1-imagedong@tencent.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat,  5 Feb 2022 16:17:38 +0800
menglong8.dong@gmail.com wrote:

> --- a/net/core/drop_monitor.c
> +++ b/net/core/drop_monitor.c
> @@ -48,6 +48,16 @@
>  static int trace_state = TRACE_OFF;
>  static bool monitor_hw;
>  
> +#undef EM
> +#undef EMe
> +
> +#define EM(a, b)	[a] = #b,
> +#define EMe(a, b)	[a] = #b
> +
> +static const char *drop_reasons[SKB_DROP_REASON_MAX + 1] = {

Do you need to define the size above? Can't the compiler do it for you?

static const char *drop_reasons[] = {

-- Steve

> +	TRACE_SKB_DROP_REASON
> +};
> +
>  /* net_dm_mutex
>   *