Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b0cdffe-b4cc-e125-f3ea-4ece582f806b@denx.de>
Date:   Thu, 3 Feb 2022 18:25:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH 16/16] ARM: dts: stm32: keep uart nodes behavior on
 stm32mp15xx-dhcor-avenger96
Content-Language: en-US
To:     Erwan Le Ray <erwan.leray@foss.st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Marcin Sloniewski <marcin.sloniewski@gmail.com>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Jagan Teki <jagan@amarulasolutions.com>,
        devicetree@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220203171114.10888-1-erwan.leray@foss.st.com>
 <20220203171114.10888-17-erwan.leray@foss.st.com>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <20220203171114.10888-17-erwan.leray@foss.st.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/3/22 18:11, Erwan Le Ray wrote:
> DMA configuration is added to uart nodes in stm32mp15x device tree.
> Delete uart4 DMA property in stm32mp15xx-dhcor-avenger96 board device
> tree to keep console in irq mode, as DMA support for console has been
> removed from the driver by commit e359b4411c28 ("serial: stm32: fix
> threaded interrupt handling").
> Delete also usart2 and uart7 DMA property to keep current behavior.
> 
> Signed-off-by: Erwan Le Ray <erwan.leray@foss.st.com>
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> index 6885948f3024..61e17f44ce81 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> @@ -376,6 +376,8 @@
>   	label = "LS-UART1";
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&uart4_pins_b>;
> +	/delete-property/dmas;
> +	/delete-property/dma-names;
>   	status = "okay";
>   };
>   
> @@ -385,6 +387,8 @@
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&uart7_pins_a>;
>   	uart-has-rtscts;
> +	/delete-property/dmas;
> +	/delete-property/dma-names;
>   	status = "okay";
>   };
>   
> @@ -394,6 +398,8 @@
>   	pinctrl-0 = <&usart2_pins_a>;
>   	pinctrl-1 = <&usart2_sleep_pins_a>;
>   	st,hw-flow-ctrl;
> +	/delete-property/dmas;
> +	/delete-property/dma-names;
>   	status = "okay";
>   
>   	bluetooth {

Maybe you can squash all the DHSOM board changes into a single patch ?

That said, the change is fine on DHSOM.