Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Feb 2022 16:12:00 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jorgen Hansen <jhansen@vmware.com>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
        Vishnu Dasa <vdasa@vmware.com>
Subject: Re: [PATCH v2 4/8] VMCI: dma dg: set OS page size
Message-ID: <Yf1CQO99mPzLg+Mq@kroah.com>
References: <20220203131237.3380-1-jhansen@vmware.com>
 <20220203131237.3380-5-jhansen@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220203131237.3380-5-jhansen@vmware.com>
Precedence: bulk

On Thu, Feb 03, 2022 at 05:12:33AM -0800, Jorgen Hansen wrote:
> Tell the device the page size used by the OS.
> 
> Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> ---
>  drivers/misc/vmw_vmci/vmci_guest.c | 9 +++++++++
>  include/linux/vmw_vmci_defs.h      | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index 5a99d8e27873..808680dc0820 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -581,6 +581,15 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
>  	/* Let the host know which capabilities we intend to use. */
>  	vmci_write_reg(vmci_dev, caps_in_use, VMCI_CAPS_ADDR);
>  
> +	if (caps_in_use & VMCI_CAPS_DMA_DATAGRAM) {
> +		uint32_t page_shift;
> +
> +		/* Let the device know the size for pages passed down. */
> +		vmci_write_reg(vmci_dev, PAGE_SHIFT, VMCI_GUEST_PAGE_SHIFT);
> +		page_shift = vmci_read_reg(vmci_dev, VMCI_GUEST_PAGE_SHIFT);
> +		dev_info(&pdev->dev, "Using page shift %d\n", page_shift);

Please do not print out debugging stuff like this to the kernel log.

When drivers are working properly, they are quiet.

thanks,

greg k-h