Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89dacc424a729c247f6431e393b89dbf8901c4c8.camel@linux.intel.com>
Subject: Re: [PATCH V6 1/3] platform/x86: Add Intel Software Defined Silicon
 driver
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Joe Perches <joe@perches.com>, hdegoede@redhat.com,
        gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
        srinivas.pandruvada@intel.com, mgross@linux.intel.com
Cc:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Mark Gross <markgross@kernel.org>
Date:   Mon, 07 Feb 2022 21:55:31 -0800
In-Reply-To: <dd4150af8858115c96ebab690182190556669050.camel@perches.com>
References: <20220208005444.487209-1-david.e.box@linux.intel.com>
         <20220208005444.487209-2-david.e.box@linux.intel.com>
         <103681860759d72b1acf712eed334b1d4ef6b7d5.camel@perches.com>
         <d52b50f3b704280e476e60417323c98f45baf54a.camel@linux.intel.com>
         <dd4150af8858115c96ebab690182190556669050.camel@perches.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-02-07 at 21:34 -0800, Joe Perches wrote:
> On Mon, 2022-02-07 at 18:54 -0800, David E. Box wrote:
> > On Mon, 2022-02-07 at 17:40 -0800, Joe Perches wrote:
> > > On Mon, 2022-02-07 at 16:54 -0800, David E. Box wrote:
> > > > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism
> > > > for
> > > > activating additional silicon features. Features are enabled through a
> > > > license activation process.  The SDSi driver provides a per socket,
> > > > sysfs
> > > > attribute interface for applications to perform 3 main provisioning
> > > > functions:
> []
> > > > +static int sdsi_mbox_cmd_read(struct sdsi_priv *priv, struct
> > > > sdsi_mbox_info
> > > > *info,
> > > > +			      size_t *data_size)
> > > > +{
> > > > +	struct device *dev = priv->dev;
> > > > +	u32 total, loop, eom, status, message_size;
> > > []
> > > > +		if (packet_size > SDSI_SIZE_MAILBOX) {
> > > > +			dev_err(dev, "Packet size to large\n");
> > > 
> > > too
> > 
> > Sorry, I'm missing the question here. If it's whether packet_size could also
> > not
> > be a multiple of sizeof(u64) the answer here is yes. But I don't see how
> > that
> > matters. packet_size is a value read from the hardware. This is just a
> > sanity
> > check.
> 
> just a to/too typo.
> 
> "Packet size too large\n"

Doh!

> 
>