Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Feb 2022 17:54:55 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Juan Vazquez <juvazq@linux.microsoft.com>
Cc:     Miaoqian Lin <linmq006@gmail.com>, decui@microsoft.com,
        gregkh@linuxfoundation.org, haiyangz@microsoft.com,
        kys@microsoft.com, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, sthemmin@microsoft.com,
        wei.liu@kernel.org
Subject: Re: [PATCH v2] Drivers: hv: vmbus: Fix memory leak in
 vmbus_add_channel_kobj
Message-ID: <20220207175455.ftlpbzzuq5wqducc@liuwe-devbox-debian-v2>
References: <20220128215604.xuqdpnnn4yjqfaoy@surface>
 <20220203173008.43480-1-linmq006@gmail.com>
 <20220206145556.72obb2qxbsktw3sc@surface>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220206145556.72obb2qxbsktw3sc@surface>
Precedence: bulk

On Sun, Feb 06, 2022 at 06:55:56AM -0800, Juan Vazquez wrote:
> On Fri, Feb 04, 2022 at 01:30:08AM +0800, Miaoqian Lin wrote:
> > kobject_init_and_add() takes reference even when it fails.
> > According to the doc of kobject_init_and_add()：
> > 
> >    If this function returns an error, kobject_put() must be called to
> >    properly clean up the memory associated with the object.
> > 
> > Fix memory leak by calling kobject_put().
> > 
> > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > Changes in v2:
> > - Add cleanup when sysfs_create_group() fails
> > 
> > kobject_uevent() is used for notifying userspace by sending an uevent,
> > I don't think we need to do error handling for it.
> 
> Thanks for the patch. It looks good to me.
> 
> Reviewed-by: Juan Vazquez <juvazq@linux.microsoft.com>

Applied to hyperv-fixes. Thanks.