Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lukasz Luba <lukasz.luba@arm.com>
To:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc:     amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
        viresh.kumar@linaro.org, rafael@kernel.org, amitk@kernel.org,
        rui.zhang@intel.com, dietmar.eggemann@arm.com, lukasz.luba@arm.com,
        Pierre.Gondois@arm.com
Subject: [PATCH 2/2] powercap: DTPM: Check Energy Model type for power values scale
Date:   Mon,  7 Feb 2022 07:30:36 +0000
Message-Id: <20220207073036.14901-3-lukasz.luba@arm.com>
In-Reply-To: <20220207073036.14901-1-lukasz.luba@arm.com>
References: <20220207073036.14901-1-lukasz.luba@arm.com>
Precedence: bulk

The Energy Model power values might be in an abstract scale. In such case
it's safe to bail out during the registration, since the PowerCap
framework supports only micro-Watts.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/powercap/dtpm_cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
index b740866b228d..e6bcde081de4 100644
--- a/drivers/powercap/dtpm_cpu.c
+++ b/drivers/powercap/dtpm_cpu.c
@@ -188,7 +188,7 @@ static int cpuhp_dtpm_cpu_online(unsigned int cpu)
 		return 0;
 
 	pd = em_cpu_get(cpu);
-	if (!pd)
+	if (!pd || !(pd->flags & EM_PERF_DOMAIN_MILLIWATTS))
 		return -EINVAL;
 
 	dtpm_cpu = per_cpu(dtpm_per_cpu, cpu);
-- 
2.17.1