Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220205081738.565394-1-imagedong@tencent.com> <20220207094301.5c061d23@gandalf.local.home>
In-Reply-To: <20220207094301.5c061d23@gandalf.local.home>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Tue, 8 Feb 2022 10:56:44 +0800
Message-ID: <CADxym3ZaMmUpZxpLrj3YMvH1nygVE5x4u6VKWZiZ98JWpRF10w@mail.gmail.com>
Subject: Re: [PATCH v6 net-next] net: drop_monitor: support drop reason
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Jakub Kicinski <kuba@kernel.org>, David Ahern <dsahern@kernel.org>,
        Ido Schimmel <idosch@idosch.org>,
        Neil Horman <nhorman@tuxdriver.com>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Menglong Dong <imagedong@tencent.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 7, 2022 at 10:43 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Sat,  5 Feb 2022 16:17:38 +0800
> menglong8.dong@gmail.com wrote:
>
> > --- a/net/core/drop_monitor.c
> > +++ b/net/core/drop_monitor.c
> > @@ -48,6 +48,16 @@
> >  static int trace_state = TRACE_OFF;
> >  static bool monitor_hw;
> >
> > +#undef EM
> > +#undef EMe
> > +
> > +#define EM(a, b)     [a] = #b,
> > +#define EMe(a, b)    [a] = #b
> > +
> > +static const char *drop_reasons[SKB_DROP_REASON_MAX + 1] = {
>
> Do you need to define the size above? Can't the compiler do it for you?
>
> static const char *drop_reasons[] = {
>

Yeah, it seems the compiler can do this job. Thanks!

> -- Steve
>
> > +     TRACE_SKB_DROP_REASON
> > +};
> > +
> >  /* net_dm_mutex
> >   *