Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8f277bb3-e604-35d5-ed60-dc8824b223b5@linux.ibm.com>
Date:   Mon, 7 Feb 2022 11:09:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v7 09/17] KVM: s390: pv: clear the state without memset
Content-Language: en-US
To:     Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc:     borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.ibm.com,
        david@redhat.com, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, scgl@linux.ibm.com
References: <20220204155349.63238-1-imbrenda@linux.ibm.com>
 <20220204155349.63238-10-imbrenda@linux.ibm.com>
From:   Janosch Frank <frankja@linux.ibm.com>
In-Reply-To: <20220204155349.63238-10-imbrenda@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/4/22 16:53, Claudio Imbrenda wrote:
> Do not use memset to clean the whole struct kvm_s390_pv; instead,
> explicitly clear the fields that need to be cleared.
> 
> Upcoming patches will introduce new fields in the struct kvm_s390_pv
> that will not need to be cleared.
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
>   arch/s390/kvm/pv.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c
> index 9e900ce7387d..f1e812a45acb 100644
> --- a/arch/s390/kvm/pv.c
> +++ b/arch/s390/kvm/pv.c
> @@ -16,6 +16,15 @@
>   #include <linux/sched/mm.h>
>   #include "kvm-s390.h"
>   
> +static void kvm_s390_clear_pv_state(struct kvm *kvm)
> +{
> +	kvm->arch.pv.handle = 0;
> +	kvm->arch.pv.guest_len = 0;
> +	kvm->arch.pv.stor_base = 0;
> +	kvm->arch.pv.stor_var = NULL;
> +	kvm->arch.pv.handle = 0;

You really want to make sure the handle is zero :)

With this fixed:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

> +}
> +
>   int kvm_s390_pv_destroy_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc)
>   {
>   	int cc;
> @@ -110,7 +119,7 @@ static void kvm_s390_pv_dealloc_vm(struct kvm *kvm)
>   	vfree(kvm->arch.pv.stor_var);
>   	free_pages(kvm->arch.pv.stor_base,
>   		   get_order(uv_info.guest_base_stor_len));
> -	memset(&kvm->arch.pv, 0, sizeof(kvm->arch.pv));
> +	kvm_s390_clear_pv_state(kvm);
>   }
>   
>   static int kvm_s390_pv_alloc_vm(struct kvm *kvm)
>