Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cda221fd-6481-598f-03ba-29d0b79af8b7@oracle.com>
Date:   Mon, 7 Feb 2022 11:40:23 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH] KEYS: trusted: Avoid calling null function
 trusted_key_exit
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>,
        James Bottomley <jejb@linux.ibm.com>,
        Mimi Zohar <zohar@linux.ibm.com>,
        David Howells <dhowells@redhat.com>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, stable@vger.kernel.org
References: <20220126184155.220814-1-dave.kleikamp@oracle.com>
 <YfGtVk/HQjgl1zSS@iki.fi>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <YfGtVk/HQjgl1zSS@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0tCV3JoNUlLakthU0kzZE14cnJrTU43WnV0RGhEZ0NPdEM4dTE3RkxBeVpm?=
 =?utf-8?B?OWIzdWxLRktzRW5wbkNBNE02cUFHUzdYbThCZUNOVnI4L1h1b0tsTGhmTmtK?=
 =?utf-8?B?enpYNUk5QlJsUmdmeFdYSDMrOVdZUHFLTzBMVEZCaWVEQTdWZ09iWnJxY2x3?=
 =?utf-8?B?dnVKUXNGd3VOZlkzaytUd3BNc0lGNVNLUTRzbko0elZ3RDluaXVIMDQyK3JD?=
 =?utf-8?B?MnUwQ2xkeTI1SEJCMGVqNnU2L1BUa3lYR25NT2JGWC9vYWFFV1NGdlF6MlN1?=
 =?utf-8?B?dndCMzl3dW4ybmJwVmFmSjV3NmlzSklNK3IxRFhiTU81VGJSWVc1TndpUEhV?=
 =?utf-8?B?ejQzN2NJbnBINFF6M3pZYkFoZ2dJMEJIbG1XdVhKdS9Ob3ljeGhXT3Z4cWZF?=
 =?utf-8?B?S3k4NmNQay9BK2RzUS9SOUd4eU9xdzJTNnpuTGI3cThhd1kvemk4UHZSRnE2?=
 =?utf-8?B?Z01lU29nWkxRYjFFc3A2RzM2WGtQZkxVR0xINWJBS1dMNW0wbDQ5RmVENmVv?=
 =?utf-8?B?VUJhQzlPaUZ3Vk83SmYvYlpHZ1llcG1ML3B5ZmNyckZ6dmZ2NTRjTnZKTVQ5?=
 =?utf-8?B?YlUrYTJBOHpjbW8wRE9ZMjU2SXBVSmVONFc3VW95NDlNVGxmRmxUWTA3d3h5?=
 =?utf-8?B?RE5lT3l6L1BsOUVlNURQWjgyN2swWnZTbTVMZWswajhUMzNqb1JJS2YyR3d2?=
 =?utf-8?B?dmYrUm1leWhoZnBRazNmVFU4cWswZXBtZUxXV2p3NjN1NXRJWkdRNHduUDBG?=
 =?utf-8?B?aTNKaGVUR2FEUnJ2K04xSnhQT1ZJSXBFWDdEdXBSUlJjZ3crMCtOWTUvdWMz?=
 =?utf-8?B?Q3lWQ2t0UGhZZ2JIQjkzcEtoa3pkWXRrdmpKU2ZTRzg1b2wzSWszaUpPdHNm?=
 =?utf-8?B?YkFWU3lqTGs5Y3g3STZLU2d2RTVNV2EyYzk0c1l0OXNJQ1JvUloreERBV3hX?=
 =?utf-8?B?UWlRYWVPZmRVY3dqMlNKNkZFa3JYcjJ0aVhJRnhBT1BtcittNlplSUxJM3dR?=
 =?utf-8?B?Zkljdy9JOVQ5N2podXJBWWI0cXhGYTVxQTRZMTZhYnhrQk5OVFBYaFAxRWVn?=
 =?utf-8?B?RUFiSjllbFE2cGM2L2k4blhkd0taaVhxZjhFNm9PbXBvWTRScjZQdTZMR05X?=
 =?utf-8?B?WXVmOHFmMHdUK2NaQWtxNmtDUkcwa3JGdE5ZWFlsY1FCd3hGS1dCc0xCWEpC?=
 =?utf-8?B?M3ByMWIvZHhPYS9qNHJ2a0o4aVM5VHg5UWxEMEtOTEZxbVdRVG96ZkM5WHVt?=
 =?utf-8?B?Tmh2YmplZmtmR0sySGZzbFBWemZ4ME5GdkxlUmVsSGlIKzJyTVowUE4zQ0hw?=
 =?utf-8?B?UmhEcDE2aG5aMkhYakFCZTdKTjN6YTE4eG9JQkJwaFRFRm44bnJldzVocjMw?=
 =?utf-8?B?UGZtQnUzUHdySGQrODliUXIwWWlLVE5xTXF1WlY0MFRQbEVUbGpwdTNkNUZF?=
 =?utf-8?B?SmpmNisxb0pXQlRlWjZqUEFETjBVQUsydHhyb00za2NEZmRpc2VveUNpT0t1?=
 =?utf-8?B?MjZRT2M0VnBMYWRHUmdPVldpQWo1WmdyNzZPVjUzSkNjQ2lJQzRpTEdGRVFX?=
 =?utf-8?B?bnVyMXNQTndTREkwOWh6b3NLVEQ3S21panZYeXdNbFpCZVNBcHI1VHA3MjhY?=
 =?utf-8?B?enZPckNEVFdqQ0U0cUNlK2k2d0ozLzdwTXRxY0dtdS9YY0lDQks0WklXUVRU?=
 =?utf-8?B?NkdNR1B4aXZLMiszT2t0ay9wUXdvTWdmcTU3a2xpTzFPb3FDNGc2SWZCRFo1?=
 =?utf-8?B?ODYra3U1L29mR2FzSllUWVdROEZPUWRHVHFKdmhFVGhOa21FMTh6MlVRR1l4?=
 =?utf-8?B?SExVK3M2YklZUHdQTlZvRXNEdXBFdllLT0hOdGVkV1pyYkRWZTMrUWRpc0hR?=
 =?utf-8?B?dGhsaE56RStVbHJNUTRNUm93emlMTnNyc2t0ZXlBMmpXNTNHQWYwQ2JzZnNa?=
 =?utf-8?B?cWJZMDk0c2RjZ0NqN00wSUFxSzNEcExRUytkVncxWEhXOExqTGhoV29RSnc5?=
 =?utf-8?B?cndyRytIRjZjWkE0U2dUVWxOeUNxRVpXMU1aQnNOVGpUM2o2ZW5LU1E1eG5X?=
 =?utf-8?B?QXkzMFdpa3FmVERla01wUk1sbEVBT0R2OSszNDFwMkZ3b01Jc0N1STQ4MVhp?=
 =?utf-8?B?bmVrcng5RnQ5SUkyTlVYM1JsMkkwNlRzNktlNVAzdlN3cXFIWFJBWXBnY3Fj?=
 =?utf-8?B?eGdmWEFKYVNiMjRudnIyMHdsWXR1TUsrQjl3N2wvcDRQL2xXMVdSYkUwS1d4?=
 =?utf-8?B?V1pMcHR4bFRJSkM3Snl6cXZGV2lnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f7e8401-ee1a-4d30-51ad-08d9ea60ec45
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4665.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 17:40:25.2767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AqjFOOilUc6yJ5TGQvrSLoeB/yZBqMt3CBMs6+w6o0xdsIVKIYcZN88s1apQCw/anm4Z3VJJKAiG5WX4/zdj02XMUvJt53nyzoHwrueHDHE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4880
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10251 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202070109
X-Proofpoint-GUID: CIqGmtd4dp8OEfo7Q7ZJUgnRPTgKMDHh
X-Proofpoint-ORIG-GUID: CIqGmtd4dp8OEfo7Q7ZJUgnRPTgKMDHh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/26/22 2:21PM, Jarkko Sakkinen wrote:
> On Wed, Jan 26, 2022 at 12:41:55PM -0600, Dave Kleikamp wrote:
>> If one loads and unloads the trusted module, trusted_key_exit can be
>> NULL. Call it through static_call_cond() to avoid a kernel trap.
>>
>> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
>>
>> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> 
> Please re-send with cc stable and the empty line removed and I'll pick it.

I re-sent a v2, but haven't seen any response from you.

I can send it again, or feel free to clean up those lines yourself.

Thanks,
Shaggy

> 
> BR, Jarkko