Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Feb 2022 15:05:32 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: Re: [PATCH 6/6] spi: tegra210-quad: combined sequence mode
Message-ID: <YgE1PD2irQeinD9N@sirena.org.uk>
References: <1643970576-31503-1-git-send-email-kyarlagadda@nvidia.com>
 <1643970576-31503-7-git-send-email-kyarlagadda@nvidia.com>
 <Yf0zkdS2nqHOZjMG@sirena.org.uk>
 <DM6PR12MB35630A9020EC4B309D877086C32C9@DM6PR12MB3563.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="L2V1A7HZ4pNge4n4"
Content-Disposition: inline
In-Reply-To: <DM6PR12MB35630A9020EC4B309D877086C32C9@DM6PR12MB3563.namprd12.prod.outlook.com>
Precedence: bulk


--L2V1A7HZ4pNge4n4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 07, 2022 at 02:54:00PM +0000, Krishna Yarlagadda wrote:

> > > +	if (cdata->is_cmb_xfer && transfer_count == 3)
> > > +		ret = tegra_qspi_combined_seq_xfer(tqspi, msg);
> > > +	else
> > > +		ret = tegra_qspi_non_combined_seq_xfer(tqspi, msg);

> > This check needs to be more specific.  But like I said in reply to the binding
> > patch I don't see why we can't just pattern match on the data without requiring
> > a property here, we'd need to check that the message is suitable no matter
> > what.

> There is no real-world use case we encountered so far preventing us stick to pattern.
> But this was to avoid any corner case where there could be 3 different transfers sent in single msg.

So you'll remove the property and just pattern match on the message?

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

--L2V1A7HZ4pNge4n4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIBNTsACgkQJNaLcl1U
h9BFNwf/ZmIVt/rPd9AefPfAWPMK3pHWlBlYzPmBgZi391BXYFZQwyI/4bJYQ7Ab
PMBM5GNFjTtqa2KFmkQ9hikJEuxTzcXckRikQ0wO+kix9rydqC/DYSxKl0Bo/y1V
syLYHM1voFHziWbqfnaFATKU88+CtaTHBNjfIqagE+MtUUZi8yeF+TJB444m4gxt
Pp4o+Ux83APBvyLsuYWYT5ua22o4ChDhAjOTQWP/fh4Eywd/yBDDw4kYDB0GYEwg
OR8NX5K+nZgz/TSavbQqeDx1NrY4WcV5TyFfGa4jajDXw1BlcgA2hZcwOMfO7MOI
GscayI2JryM5qaUgVL3vSM7ePri9Jg==
=5TVG
-----END PGP SIGNATURE-----

--L2V1A7HZ4pNge4n4--