Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Feb 2022 10:27:53 +0100
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     alexandru.tachici@analog.com, davem@davemloft.net,
        devicetree@vger.kernel.org, hkallweit1@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        netdev@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45
Message-ID: <20220207092753.GC23727@pengutronix.de>
References: <20211210110509.20970-1-alexandru.tachici@analog.com>
 <20211210110509.20970-5-alexandru.tachici@analog.com>
 <YbUTJdKN9kQAJzqA@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YbUTJdKN9kQAJzqA@lunn.ch>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Alexandru,

On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > +		ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > +		if (ret < 0)
> > +			return ret;
> > +
> > +		if (ret & MDIO_PMA_EXTABLE_BT1)
> 
> 
> This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> is expected to change is it? So i wounder if it should be read once
> and stored away?

What is the state of this patches? Will you be able to make requested
changes and send new version?

Regards,
Oleskij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |