Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp978120pxb; Tue, 8 Feb 2022 06:47:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsxIKq7DWqHb7HbcBR0GiSljn+NFwEc+mHkoUbe+GksGin++h08MLp+iZjmOK9F/KGe3Co X-Received: by 2002:a05:6402:528c:: with SMTP id en12mr4910966edb.415.1644331626353; Tue, 08 Feb 2022 06:47:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644331626; cv=none; d=google.com; s=arc-20160816; b=MomLELFsjHi5V4V3z0lfUlb/kXKiujMkOX/8sP5RvAMVprPwJWf6YyWmtpn34HnkVv H1q/TwZ8o1T3Z8ThBnhL5KgsnMC3w8t8xmzhvL73JkAh3rriiAw7+JopvwEuzjtLRmje YDJ7h+gnfrx6lAa5xQQUDuijJQyUTEBlL9qqdsDp24I9ei59MC/QpDFFDs0xe4qw10m3 QWKByhKILj6RMyMlaChlNUlFUD3BIPXRjQ1o/aymCGHnrqGp5AvsmbyyyPunJX0X4nSQ 1g9kmu0T6VGjSvIHZxkYooZVBRVwi6C8qbJtIK6IQfRSp65N7mZ37wMQocCYkHPlGEIy DLuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AvJ9N+RokT/quaPmMZhpaU8mvk15cL5DRf0vZEA2K/0=; b=lcG6yE0Y39BgOE6Xo5xspEhRnWLwUFeg+F4IITsNEFLJ7zigsbpzymq2ZXl8pXmFkC MmCcA3OTW4W16qKQEYQMbsiOE9kVtHm2qnLWuSJgVcp/ovyEHaSxRs9w33Y5XAHLoxz2 t2rez5Q/4fz8QvI5K1iIZJ28YXHqji3IEfYOpSdHZmylL9OYAH0XC8jvIXa3SeN8FRM0 +gvwNvgMUbPTgzAWMjiooq1eSUPPTFKs+/DJk9H+3MTjdmzqg9WS7TJQKBZIMuqfUX1C vvNdrWdAJrZZ7Gu92XgnWoY86M0bWhAnsk9XkZyAJeo25C8z0p2zY6hYGcFh5yxjtFdy 1Mqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HiiucCUT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5si10345533edi.611.2022.02.08.06.46.40; Tue, 08 Feb 2022 06:47:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HiiucCUT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240265AbiBGVj4 (ORCPT + 99 others); Mon, 7 Feb 2022 16:39:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240208AbiBGVjw (ORCPT ); Mon, 7 Feb 2022 16:39:52 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AA7E4C061A73 for ; Mon, 7 Feb 2022 13:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644269990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AvJ9N+RokT/quaPmMZhpaU8mvk15cL5DRf0vZEA2K/0=; b=HiiucCUTqHgj2undT9qDpunUqVFyFPZbAJJwXVihnIOdCHk+blxDb4/sdCJ+qac4r0KZv5 P/IJUweghEsBXu2QWYFIsiB9FY+djpaPQQdykhBDELzcMkV8I8XXmidCD43Rd1TEQYFvaJ pm9uktXUwWmihiY3tKWD2wybhef6u0w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-vgSPi0YHOzOjbRTZsRCqcQ-1; Mon, 07 Feb 2022 16:39:45 -0500 X-MC-Unique: vgSPi0YHOzOjbRTZsRCqcQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D0B1101F7A1; Mon, 7 Feb 2022 21:39:43 +0000 (UTC) Received: from emerald.redhat.com (unknown [10.22.8.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A52E1037F38; Mon, 7 Feb 2022 21:39:34 +0000 (UTC) From: Lyude Paul To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Gwan-gyeong Mun , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= , Jani Nikula , Rodrigo Vivi , stable@vger.kernel.org, Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Daniel Vetter , Matt Roper , Lucas De Marchi , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/i915/psr: Disable PSR2 selective fetch for all TGL steps Date: Mon, 7 Feb 2022 16:38:20 -0500 Message-Id: <20220207213923.3605-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues is to just move the cursor around the left border of the screen (suspicious…). So, fix people's displays again and turn PSR2 selective fetch off for all steppings of Tigerlake. This can be re-enabled again if someone from Intel finds the time to fix this functionality on OEM machines. Signed-off-by: Lyude Paul Fixes: 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch by default") Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Cc: José Roberto de Souza Cc: Jani Nikula Cc: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org Cc: # v5.16+ --- drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index a1a663f362e7..25c16abcd9cd 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -737,10 +737,14 @@ static bool intel_psr2_sel_fetch_config_valid(struct intel_dp *intel_dp, return false; } - /* Wa_14010254185 Wa_14010103792 */ - if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) { + /* + * There's two things stopping this from being enabled on TGL: + * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792 are missing + * For all steps: PSR2 selective fetch causes screen flickering + */ + if (IS_TIGERLAKE(dev_priv)) { drm_dbg_kms(&dev_priv->drm, - "PSR2 sel fetch not enabled, missing the implementation of WAs\n"); + "PSR2 sel fetch not enabled, currently broken on TGL\n"); return false; } -- 2.34.1