Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Feb 2022 14:41:20 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzk@kernel.org>,
        'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v2] regmap-irq: Use regmap_irq_update_bits instead of
 regmap_write
Message-ID: <YgKBEIapL8MAQAoI@sirena.org.uk>
References: <20220119142953.1804-1-quic_pkumpatl@quicinc.com>
 <CGME20220208122955eucas1p2d4e32f51224242e9ebd0bce58b9c04ca@eucas1p2.samsung.com>
 <39f1b598-58ca-1e3d-3065-8dd692ee7c9f@samsung.com>
 <20220208133957.GC112838@ediswmail.ad.cirrus.com>
 <20220208135036.GD112838@ediswmail.ad.cirrus.com>
 <YgJ2hG2vwUclA/zF@sirena.org.uk>
 <20220208143316.GE112838@ediswmail.ad.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jv8MBE5QGK8kAXmU"
Content-Disposition: inline
In-Reply-To: <20220208143316.GE112838@ediswmail.ad.cirrus.com>
Precedence: bulk


--jv8MBE5QGK8kAXmU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 08, 2022 at 02:33:16PM +0000, Charles Keepax wrote:
> On Tue, Feb 08, 2022 at 01:56:20PM +0000, Mark Brown wrote:

> > My understanding was that they'd mixed interrupt handling in as a
> > bitfield in another register.

> Eek.. what a courageous choice. I guess that might work as
> long as there is only a single IRQ status bit in the register,
> if there are multiple bits this really needs more complex
> handling, like you basically need the old behaviour for the
> IRQ part of the register, and the new behaviour for the not
> IRQ part of the register. So perhaps a new mask to denote which
> bit of the register is being used for IRQ stuff?

Yeah, I think that's what I misread the code as doing.

--jv8MBE5QGK8kAXmU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICgQ8ACgkQJNaLcl1U
h9CuOQf/f55QEPYWcJesb5ASdVandS6mWWUT3NZ4QOrbearecpyY1z2pPh3zx7Yu
qUVYuvfLMfJvSPsjtGHi2THg5eX+ctxJdpsflYf1SDGEQnX1dREsJl+1giBVqogn
ybLMXZmEvzKOYoR9q0MZMw8baesjtlpirunaXvvK7ctnTB/5hfR/Slmm9dqwt2Ph
PoElLbFPTzlvKFYccAyr6dsCxgbL1cV7rw0dSMdreAD7b7Is1V9X0zmq6bPPS0g5
qXG3XIjUDDMqB1gNvAEqz8vUx4sqrh1SHkpyIDjfb5cC4dn1ANqiKeVbkzhTSCky
cciN+AtOT6e9JkzbRLN3gVG8rq08aw==
=Y0qE
-----END PGP SIGNATURE-----

--jv8MBE5QGK8kAXmU--