Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1155397pxb; Tue, 8 Feb 2022 10:28:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQXknLH8ZydjC/DwCY72eHVlmno/nfPbBGqrAI6fxGqMhP2fVMcf2wodz2O8uuBZWWuJlJ X-Received: by 2002:a17:902:ef49:: with SMTP id e9mr5481563plx.56.1644344902453; Tue, 08 Feb 2022 10:28:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644344902; cv=none; d=google.com; s=arc-20160816; b=fJQF7RDS8qJLUsJn1mDYJEZr/X+O9hjRoQePlN9TnmOfbZFgCn38zrbx/9D7Jnu6Nk u20Z7KbXYjLAnNMX65f/wGrEYFo+9KCJGs2k/cLLkQ0Wh5KMRtqWREZjgxmAuv4TqDR+ kyYdvZRYUvsa1cgLIhTS+hIAa/+u4th1QY9jZ5OKjQ/AATmTFWnMOCEjxZALA/l/bK+1 SxuPtm6EEvxNoDrapA/isj1Y8XIyaEGDSr76c+XmLiu5MLg6mIQ76Pl7D7kQtt/uoWvH xkCv175jAhYgwtiHzAXA9CJC579b91fVpuUemuRjp6oHloqPj6pieScx3iBm/bTgXoel 7nhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=kqCsGeRIUc8uroidDGE7+5/fcCfxwNgv05WOZpJYzto=; b=qJjmoIf/o+rcHnORTrz5LVi19lOnUck2J7qtXaq9QnAsDOEiZwxWPQGheNhJaPotk8 5p3aQqHdLfFHvOncNZ5oak9JDS/QI7PJ/Xd6CDX9ODGaIqvuCncdaPcN30yJZgQ0Uq1L TOkdVv4rlqMjkDZ/aFJcsQk7DbVEtet3TNutXLkfhCuRe5YxXSiq/AEzqts5qxNm0qrp PIwC5zLBJUJaOWVgFTx4aqjii6wr5xIbnJPNQJa6OWoIPupLw43uWYAM5HJgGS2CP9f8 QFbIB+kM0SotT5QeF8mOG8ikvW62cNKYLujotJJ8J2/C2iM4A6LcxskKocjggqJ4V708 kCDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u185si1583326pfb.158.2022.02.08.10.28.08; Tue, 08 Feb 2022 10:28:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352009AbiBHIoC (ORCPT + 99 others); Tue, 8 Feb 2022 03:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351427AbiBHInj (ORCPT ); Tue, 8 Feb 2022 03:43:39 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8F02C03E931 for ; Tue, 8 Feb 2022 00:43:27 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHM5r-0002Xc-Q8; Tue, 08 Feb 2022 09:43:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nHM5q-00FGOF-Re; Tue, 08 Feb 2022 09:43:22 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nHM5o-00Bgwf-VR; Tue, 08 Feb 2022 09:43:20 +0100 Date: Tue, 8 Feb 2022 09:43:18 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Lee Jones Cc: Christophe JAILLET , Thierry Reding , Daniel Thompson , Jingoo Han , Helge Deller , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] backlight: pwm_bl: Avoid open coded arithmetic in memory allocation Message-ID: <20220208084318.pkfs6xtpe4cz77sd@pengutronix.de> References: <20220207080128.xmvommcddjfgz7ey@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pdixcmr5l2jhzb4h" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pdixcmr5l2jhzb4h Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 07, 2022 at 09:31:00AM +0000, Lee Jones wrote: > On Mon, 07 Feb 2022, Uwe Kleine-K=F6nig wrote: >=20 > > On Sat, Feb 05, 2022 at 08:40:48AM +0100, Christophe JAILLET wrote: > > > kmalloc_array()/kcalloc() should be used to avoid potential overflow = when > > > a multiplication is needed to compute the size of the requested memor= y. > > >=20 > > > So turn a kzalloc()+explicit size computation into an equivalent kcal= loc(). > > >=20 > > > Signed-off-by: Christophe JAILLET > >=20 > > LGTM > >=20 > > Acked-by: Christophe JAILLET > >=20 > > Thanks > > Uwe >=20 > I am totally confused! An rightfully so. Copy-paste-fail, this was supposed to be Acked-by: Uwe Kleine-K=F6nig Sorry! Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --pdixcmr5l2jhzb4h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmICLSMACgkQwfwUeK3K 7AkbYgf/RNIxNrujniat17dztKQmOsg7ALfQgtXaD7tJg70b7hHEABMPGSfUeTD4 NmvXDBOnN1LiF8tOP/wJQlsM+vQzWJfIT4IQkiravbjwlUW4dgP7791/tH96r0uk S5Cz5KuSYksD6aj/RnsSC5lGtXQzjX2u7zC/H0oIMdOQ7VotZMSsKYVkkayAukP4 HY6htMhSXDfTLemlM0oVWGOwMzO+LvG1szPEKsUdaOTiT0qMMozlRBd+gt/4Panz OnodFwSXAmgEH9IH+s/wH8xsVe5TYibaqhPnsj9JBaMRjGVNnCf7ziwL+BSC3P1m 6guPRpOxNHkPy8j+kGt+RekqdmL/QQ== =Iulx -----END PGP SIGNATURE----- --pdixcmr5l2jhzb4h--