Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Alan Stern <stern@rowland.harvard.edu>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Tao Ren <rentao.bupt@gmail.com>, BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH] usb: ehci: add pci device support for Aspeed platforms
Thread-Topic: [PATCH] usb: ehci: add pci device support for Aspeed platforms
Thread-Index: AQHYHLU/wak6DMtWCU2KemAPJzVaSayJRCQAgAALm1CAAAZMgIAAAwMw
Date:   Tue, 8 Feb 2022 08:53:37 +0000
Message-ID: <HK0PR06MB32021B3CDD6F04614E471234802D9@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220208062927.3527137-1-neal_liu@aspeedtech.com>
 <YgId0AhvRAmIcEA0@kroah.com>
 <HK0PR06MB32026A17E53EB76DB898A399802D9@HK0PR06MB3202.apcprd06.prod.outlook.com>
 <YgIs1fIu9nzuCKeA@kroah.com>
In-Reply-To: <YgIs1fIu9nzuCKeA@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vCpdDJcHHwu3DMvR6I5Te3QmZJGb1xzdP6SMZWvWmSg3Y2j8ZQp33G4kWppz?=
 =?us-ascii?Q?djLpbiZGYa1OylnurNdGFuXkcvLhaU7RvakiW1eZqMyBetxt6cnmQBy0Ezj9?=
 =?us-ascii?Q?KXLQPGGQuiOcGXhgoTOpM/PGXnipm+wzKj4EICHqqaEN/JU2GGWYs7SEKVaI?=
 =?us-ascii?Q?YruqfB5Ho/aBWDHhlEr3bNHAscSR7LW6H28jmfDn+cz71fDCK2BUJHF55RSg?=
 =?us-ascii?Q?6GgA8YvkQdee6M5JFYUUt0J8QWAQh8C/DUiR9PRddWdlH7yJw+YxbYXF8ded?=
 =?us-ascii?Q?r87GVA/oFSPEpGLmtg/az8chPE4XFUnyQwvcbhcPub67Wl4RFNwZhy4Df7nx?=
 =?us-ascii?Q?Tu4++H6Q0qlnFOJ7QGG8bfbzu5oNGMWwS7VhJGQ7mOFL/zfkzT3uonQgxIdT?=
 =?us-ascii?Q?hkrbIoYjNwDMpR7nkXokI37PVP61sL8MqgVQjDds2390zT7+toizQliGZdm5?=
 =?us-ascii?Q?U0tIgDP/onUk3ODUopQGHylak61wT9yWzisr6LqMj2oGyr4TxWpUfrF5CC+0?=
 =?us-ascii?Q?qMEqAS88h1Ad7u6iMFLHgS8dSQt7WkK/KnqZ3DQfrAZXFXN+kT6Aq6Xlw1Hs?=
 =?us-ascii?Q?C8a82CdFW+5L0Kvltzf4gMhVvj06bifH/ARk586yWRvSOsS3YO5BDbgFcbPG?=
 =?us-ascii?Q?aQvaB3cbonzAOeiBs7BkBR+qEQGcWwJFM9tzoBCnYTxKS5d4G51cOcYLHsb5?=
 =?us-ascii?Q?1bCenanXDZIlh7Kjk65o1kWQ91ml9vYsz5zzMpVdUL6ctTSkr5L3z/LHNosJ?=
 =?us-ascii?Q?UTB/SsqJKA0GAQx3BfCHSTe3zuuNXQfaEdfA5mLyJ41batsxO9gexiV7xWY1?=
 =?us-ascii?Q?TTHTqjx+uqFO6/GmgymecmbQ1F5fbDiQUHMrMkMGE5l0MCPezbv35XgZaNl7?=
 =?us-ascii?Q?TE0zKq/Z4dfQLwIKHgInq5CTNtJXnUhtLWV2XSq9/p37Q/E8hjx8++hV9T+G?=
 =?us-ascii?Q?1N+lQUEQQVBAnk+sVowfECeiTsJghg9967xvhWOwZhY/GJf0NzND2Nb53Lpt?=
 =?us-ascii?Q?lIRsFbEjmEQ3BAxtTQ6gsLqlgCofH3nl0Rwl+7CtcVkx7Z5dr3N+DsAedgDh?=
 =?us-ascii?Q?fh1OfzoOGSCWJwv59S2cHDhNCoaFEcFbM0mg+fDDDfZVhyQiyWMlML7TMQWb?=
 =?us-ascii?Q?jVhlTxzDRQAA8cSlGpgr3X7spXZsG0dLAtK+xRW8zRf8PdvuDQixVVvN+h/Y?=
 =?us-ascii?Q?nnho2mASrK+uN49WvZAl79PAxKotiPXo/8y/tXd3l+TdGTNIQCcQ06oszp+H?=
 =?us-ascii?Q?x7JvxtUZkgi/dyJu0B7h7iuXrRxLQR5BnHkdhRjWGohwNfmtfecyDvEFbcjY?=
 =?us-ascii?Q?lqXGtXwnwX9L0W9BULDX0SCYIZYywjS7pBb97mkirQvh5WfNbmnFvCmUcqUe?=
 =?us-ascii?Q?xS0QAWm5i1Hf0FZqAMdUudPHCHf9zWQzbAGs40GTX86eoyLeQOC+4cNvTYBu?=
 =?us-ascii?Q?gI8UrrBf8wPUJE6JrTjfGitGBeA9iTzDhIrATdDcbT74XW+8MYw/WQXv6zIR?=
 =?us-ascii?Q?bMHeOdUhv42M1lJDA8NrOOtdSB2JYtWm8WW0oFZKD4Ia85UOJYwtZFTKuqE8?=
 =?us-ascii?Q?FpHfCv6VlrZtr3ZDhPMgx3T8oSmTTuOLhaVMiIhNXCyDEAJLfB/oesdJLpp0?=
 =?us-ascii?Q?pWpqUzXMmmHp95PzTtykXdM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0c38cab-3057-4beb-c93d-08d9eae07f3d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:53:37.6402
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PH5cJGEyQcH90A8IeQfWjndQhZ/eR1/WnwDubUjY44uf0Wz4ASgzS/1iZJnQGl3l2OL6m93RoL9xH/bypA3TUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3838
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Tuesday, February 8, 2022 4:42 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>; Bjorn Helgaas
> <bhelgaas@google.com>; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org; Tao Ren
> <rentao.bupt@gmail.com>; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH] usb: ehci: add pci device support for Aspeed platfor=
ms
>=20
> On Tue, Feb 08, 2022 at 08:20:07AM +0000, Neal Liu wrote:
> > > -----Original Message-----
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Sent: Tuesday, February 8, 2022 3:38 PM
> > > To: Neal Liu <neal_liu@aspeedtech.com>
> > > Cc: Alan Stern <stern@rowland.harvard.edu>; Bjorn Helgaas
> > > <bhelgaas@google.com>; linux-usb@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org; Tao Ren
> > > <rentao.bupt@gmail.com>; BMC-SW <BMC-SW@aspeedtech.com>
> > > Subject: Re: [PATCH] usb: ehci: add pci device support for Aspeed
> > > platforms
> > >
> > > On Tue, Feb 08, 2022 at 02:29:27PM +0800, Neal Liu wrote:
> > > > Enable Aspeed quirks in commit 7f2d73788d90 ("usb: ehci:
> > > > handshake CMD_RUN instead of STS_HALT") to support Aspeed ehci-pci
> > > > device.
> > > >
> > > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > > > ---
> > > >  drivers/usb/host/ehci-pci.c | 6 ++++++
> > > >  include/linux/pci_ids.h     | 3 +++
> > > >  2 files changed, 9 insertions(+)
> > > >
> > > > diff --git a/drivers/usb/host/ehci-pci.c
> > > > b/drivers/usb/host/ehci-pci.c index e87cf3a00fa4..a91b25d216ae
> > > > 100644
> > > > --- a/drivers/usb/host/ehci-pci.c
> > > > +++ b/drivers/usb/host/ehci-pci.c
> > > > @@ -222,6 +222,12 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
> > > >  			ehci->has_synopsys_hc_bug =3D 1;
> > > >  		}
> > > >  		break;
> > > > +	case PCI_VENDOR_ID_ASPEED:
> > > > +		if (pdev->device =3D=3D PCI_DEVICE_ID_ASPEED_EHCI) {
> > > > +			ehci_info(ehci, "applying Aspeed HC workaround\n");
> > > > +			ehci->is_aspeed =3D 1;
> > > > +		}
> > > > +		break;
> > > >  	}
> > > >
> > > >  	/* optional debug port, normally in the first BAR */ diff --git
> > > > a/include/linux/pci_ids.h b/include/linux/pci_ids.h index
> > > > aad54c666407..410b395fe56c 100644
> > > > --- a/include/linux/pci_ids.h
> > > > +++ b/include/linux/pci_ids.h
> > > > @@ -3096,4 +3096,7 @@
> > > >
> > > >  #define PCI_VENDOR_ID_NCUBE		0x10ff
> > > >
> > > > +#define PCI_VENDOR_ID_ASPEED		0x1a03
> > > > +#define PCI_DEVICE_ID_ASPEED_EHCI	0x2603
> > >
> > > Please read the top of this file, this does not need to be added here=
.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Are you suggesting to hard code vendor/device ID in driver instead?
>=20
> Or put the define in the ehci-pci.c file like other drivers do.  Only add=
 to the
> pci_ids.h file if your define is needed in multiple drivers, otherwise it=
 is a
> merge nightmare.
>=20
> thanks,
>=20
> greg k-h

Okay, I'll revise it. Thanks for your suggestion.

-Neal