Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Alan Stern <stern@rowland.harvard.edu>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Tao Ren <rentao.bupt@gmail.com>, BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH] usb: ehci: add pci device support for Aspeed platforms
Thread-Topic: [PATCH] usb: ehci: add pci device support for Aspeed platforms
Thread-Index: AQHYHLU/wak6DMtWCU2KemAPJzVaSayJRCQAgAALm1A=
Date:   Tue, 8 Feb 2022 08:20:07 +0000
Message-ID: <HK0PR06MB32026A17E53EB76DB898A399802D9@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220208062927.3527137-1-neal_liu@aspeedtech.com>
 <YgId0AhvRAmIcEA0@kroah.com>
In-Reply-To: <YgId0AhvRAmIcEA0@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rTJbzwO9b8r6qqrwuWrXBu1yJA5+2f7KICkpFwBB+1Qd19nqiiuQ8gx1KE/H?=
 =?us-ascii?Q?GcgjU9uLaYWXEBMYQQp6Tu8dFY90dPCqrh2lf5Rjwm7nklq2IRsul2q2CqPT?=
 =?us-ascii?Q?HpTJfFgt1QOud5Zqwpkm1cgd7a2p/xMFF6eVvg/ZpbhbksAzL+A0eu7hGcCR?=
 =?us-ascii?Q?0axHbvzHcoUL1SltttbSrLaABmVr10exRVjFP33Cl9iDBN1I1SYq9DTJ8i3v?=
 =?us-ascii?Q?axoIcAqv84JDvcHaXe22pRE32AooILUFxlTBfOFXa0hq5rl+x2litv7+NBHh?=
 =?us-ascii?Q?KZ+A0YpdSeKoLKJJeKqOG+AGIZKgAeAE0dxb5Ux3DNjfRakCet73NxFjsxfu?=
 =?us-ascii?Q?kuYAKaDBggAtKxB3nStQi2AmJB/OngoEib9sI6t0Vr1Ns0xsHbokSZ2N0PWU?=
 =?us-ascii?Q?aUsjw02FA+k17EQ7rPfX2uQkzOmVm9wvUqGWPqdUSoGsC58/EtlV4S3Urs+V?=
 =?us-ascii?Q?Dy8AGAPDNnNsOhWdVO2MCCBbxgyMVQUW7v69D20upOyUqgyFDTUAIHBcTTMi?=
 =?us-ascii?Q?1bd2+PBTm3ApdBnQxylPp03uAswgF2lVMa1/B1696w2EJu/WwtBTFs3lbIQZ?=
 =?us-ascii?Q?TYGRfNMJJugl7h53aPRkVb7KQd4Ofdfb5m1r8EVEDR1VJ4h0YopyoEFfV94j?=
 =?us-ascii?Q?YEydZcDCia7omJGWHm2h4hDoR+colGke4xIwNeN3VmYlAa/7ORs3Hc+5Oq4I?=
 =?us-ascii?Q?BfVDcs/RsHu4+u5lXizj7IhtJ+/UILDwveqXQWYt1G99XG43IrqTo8XrnkRc?=
 =?us-ascii?Q?koHWLfRfE1Zmi6o4JxqRUixM3PtajCOK2+UM/wWrZhFqYPB5WDbDzV0EuruL?=
 =?us-ascii?Q?TxCEabnHpQ4J+djTvKyCVnsQVvyyRwJMl9ir7EGd8WDNvrUmd6K5ngpZQYVl?=
 =?us-ascii?Q?D0cvwCFbBl6+zxiu+qDEW+4RH5u9hXCmjxC+uuOu9RH0/j+BmnLRa2ajE4RH?=
 =?us-ascii?Q?ORN782nvqc82X5f5aQQE/ep6rbz6b23yhOTxtV0qp+1VbCMvFDXBPeeTDChW?=
 =?us-ascii?Q?ClP/OAu4AV+u2rTfuR5woQ/mfuYNMGc8wIov/lCpgxcDU4fivev8WHQND8Ih?=
 =?us-ascii?Q?gWBps/CmASksLZ+3IteRA2Yq4FftPFLN4o5Qa6aTa1JMm64g8vIOqvFoSsyc?=
 =?us-ascii?Q?2CpHBkkqrJJ9Brn0F0NSyn5JVCXDR7ckR2nm2dExodOdiIwQcGle0BBhay90?=
 =?us-ascii?Q?5+fsaLevJq+6Y5yx8I+3J0sDk11kG0Dh5CqZvXQm3aKaqjyRJ9yrhI0/qdMn?=
 =?us-ascii?Q?HWWwHrEn5/5RGwiRhSZq1Cjpu6B+1Qs3uvvjo53EkdxvxMpWgwV9RUc08oG+?=
 =?us-ascii?Q?348ZJfeCy5DzE2N9DOPL27uAfxJfPBTc3WHyZaMmR5PWXcIfJbUmgqIb6N2e?=
 =?us-ascii?Q?g2NDlnuU4vl0VJs5numT8M+bxYQtQR1MUsfIeJuZyw1Kt5LrHZEA5a21UxTd?=
 =?us-ascii?Q?yLdh1egguu2s457nox1GFGU/t3qRiQjWGvtvltxwrAyXLeefyGPE5OgktXbW?=
 =?us-ascii?Q?8lBub9MHMcYB1bgmw9W2sE27kiC9GkVW3FP62Ws95mDmN53CHDRsdTFjO31q?=
 =?us-ascii?Q?2eM5RWTtNJ04+zW/9UtIYTdRWY77Obo9g14PKWt895v7msjmGyIGwsUooE7v?=
 =?us-ascii?Q?+Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e43b5d9-f6c3-450b-64ac-08d9eadbd125
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:20:07.4449
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6rsZpcKhtGF4N+QtAEJYtG1KQX17ZPNnJeoCshm4yKYDJa+PdfzRgwKSo438Fp26ygpCTgdZDn9ffVLS0HTHfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2512
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Tuesday, February 8, 2022 3:38 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>; Bjorn Helgaas
> <bhelgaas@google.com>; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org; Tao Ren
> <rentao.bupt@gmail.com>; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH] usb: ehci: add pci device support for Aspeed platfor=
ms
>=20
> On Tue, Feb 08, 2022 at 02:29:27PM +0800, Neal Liu wrote:
> > Enable Aspeed quirks in commit 7f2d73788d90 ("usb: ehci:
> > handshake CMD_RUN instead of STS_HALT") to support Aspeed ehci-pci
> > device.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  drivers/usb/host/ehci-pci.c | 6 ++++++
> >  include/linux/pci_ids.h     | 3 +++
> >  2 files changed, 9 insertions(+)
> >
> > diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> > index e87cf3a00fa4..a91b25d216ae 100644
> > --- a/drivers/usb/host/ehci-pci.c
> > +++ b/drivers/usb/host/ehci-pci.c
> > @@ -222,6 +222,12 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
> >  			ehci->has_synopsys_hc_bug =3D 1;
> >  		}
> >  		break;
> > +	case PCI_VENDOR_ID_ASPEED:
> > +		if (pdev->device =3D=3D PCI_DEVICE_ID_ASPEED_EHCI) {
> > +			ehci_info(ehci, "applying Aspeed HC workaround\n");
> > +			ehci->is_aspeed =3D 1;
> > +		}
> > +		break;
> >  	}
> >
> >  	/* optional debug port, normally in the first BAR */ diff --git
> > a/include/linux/pci_ids.h b/include/linux/pci_ids.h index
> > aad54c666407..410b395fe56c 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -3096,4 +3096,7 @@
> >
> >  #define PCI_VENDOR_ID_NCUBE		0x10ff
> >
> > +#define PCI_VENDOR_ID_ASPEED		0x1a03
> > +#define PCI_DEVICE_ID_ASPEED_EHCI	0x2603
>=20
> Please read the top of this file, this does not need to be added here.
>=20
> thanks,
>=20
> greg k-h

Are you suggesting to hard code vendor/device ID in driver instead?
Thanks

-Neal