Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1319344pxb; Tue, 8 Feb 2022 14:34:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEfO0lufwG8k15iZf1xIIhjPeTe2gHD5ry3OxR3irJrOEQnzWvkoTTfQYuGtNij+Jk2qzy X-Received: by 2002:a17:90b:1e05:: with SMTP id pg5mr142639pjb.127.1644359665523; Tue, 08 Feb 2022 14:34:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644359665; cv=none; d=google.com; s=arc-20160816; b=bTak589pDjZKIQQaIY4n4vnySDDM/7qSYrS5145l4CCQ5gfrypAvSB/NP8zMpgBkjx cWZvqHaDF9rkTzV9SNMT1XkJXJy0FdTojSk9UsnVz0z8Z/IbHPRxE1XLvjC8B/NWsrJR F/579v9x6XsryssUZmr+fFqnUUJg2dUMpREmRiMXY17+NCt2d8FzSLZyGCbxhvnitVl/ eMbUD3lQZ+Jul0ZspSSebSG25DoUeiSkg4rIw0wNidr4/EbwgPBe7PoJSaM7hcUkViPO cLA9zJAgBmhQbde77HO+b9aT1LbPOacIdR5JOqjYuqlXrWzLLGfJJlq1HkMOmfScOHU6 OXwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=g573CcFbfs0s4wW1z2wLmTrb8XZv6WBjGjEO7RDJLuo=; b=e8EwKQYEdOB8RNyymISOE46AegqBUDJLcx1FJnylqOrzFhskfNpWVfQ/qXxVhkE5Kx rCN6EXgx8VE9vGsnmF2uzdXP4AGW6eqpHtAYX2e0pCxICiSpDBDk1lY3EdfFqvZ3KadI obI5sbxdYcyZYxlRTvzhWc2Jck1shqOI8joKNYrofGEg9710PFsifPpuO72uaOeRq5kG 38UUPaoIxaAhq7X6VVJgIpGPLLtmoCyG8xDyspBKH0O5v13B2P87FWC28q5uiX7QhkUr /c4yJIGhuWk3cxh0H+YhUtI0YR+alTvSjryIDeXGbAiQXK2bWkG8GLE+m43/2yYXdWuW Dr7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="cHFRU7f/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12si12479604pls.575.2022.02.08.14.34.11; Tue, 08 Feb 2022 14:34:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="cHFRU7f/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239545AbiBGPIq (ORCPT + 99 others); Mon, 7 Feb 2022 10:08:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442386AbiBGOuD (ORCPT ); Mon, 7 Feb 2022 09:50:03 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 530DDC0401C1; Mon, 7 Feb 2022 06:50:03 -0800 (PST) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 217DsU4c009698; Mon, 7 Feb 2022 14:50:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=g573CcFbfs0s4wW1z2wLmTrb8XZv6WBjGjEO7RDJLuo=; b=cHFRU7f/IS8p7w2Y21k0C53KOApK8G3QRaC17dpO0fkPhOhAN6DVUHN2KuliMNKMoLY0 AqcXbpGxoSI2YJmbS4jgJ0YjAc0GpXqe482tv7nSG3ndUW3rPgLGuDq8smycGhTKwzrh tiGQ0qmNz+d1A79mxYFLDM5qZMWsvMTxAne9ujwcR6nPtK71yAtHHNGBxN2T1xUBYkun wrUx//8BI+cY1r4RpzWfmeY1Btou9NedgbuczrK6/WhrZ/IPajA0EyOHC5NXC/EfvalR WUPX2yiHU2Aom99KyKrer+xPVlJuoktEgSEGtHC9DzIwK2BqifUXQrMVP5x3zfzxQa0q xA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e22q0xhyq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 14:50:02 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 217EBTSd023357; Mon, 7 Feb 2022 14:50:02 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e22q0xhxx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 14:50:02 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 217EmTH7028159; Mon, 7 Feb 2022 14:50:00 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 3e1gv95tfy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 14:50:00 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 217EnuS945744602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Feb 2022 14:49:57 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D56134204D; Mon, 7 Feb 2022 14:49:56 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A7D042042; Mon, 7 Feb 2022 14:49:56 +0000 (GMT) Received: from p-imbrenda (unknown [9.145.11.12]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 7 Feb 2022 14:49:56 +0000 (GMT) Date: Mon, 7 Feb 2022 15:49:54 +0100 From: Claudio Imbrenda To: Heiko Carstens Cc: Janosch Frank , kvm@vger.kernel.org, borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.ibm.com, david@redhat.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, scgl@linux.ibm.com Subject: Re: [PATCH v7 01/17] KVM: s390: pv: leak the topmost page table when destroy fails Message-ID: <20220207154954.52492029@p-imbrenda> In-Reply-To: References: <20220204155349.63238-1-imbrenda@linux.ibm.com> <20220204155349.63238-2-imbrenda@linux.ibm.com> <0939aac3-9427-ed04-17e4-3c1e4195d509@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jLWkRWNQd2OpDjO8SsZimqRobGt9MSRh X-Proofpoint-ORIG-GUID: 0bnFswUWAYvvTgWUnAiGFUw9vAPZZ8ES X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202070093 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Feb 2022 15:33:15 +0100 Heiko Carstens wrote: > > > + asce = (gmap->asce & ~PAGE_MASK) | __pa(table); > > > > Please add a comment: > > Set the new table origin while preserving ASCE control bits like table type > > and length. > > And while touching this anyway, please make use of _ASCE_ORIGIN > instead of PAGE_MASK. will fix