Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59da7f3e-92bd-1165-00e3-3dc18ae19aea@kernel.org>
Date:   Tue, 8 Feb 2022 09:35:29 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] f2fs: avoid unneeded preflush during checkpoint()
Content-Language: en-US
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20220207113516.9489-1-chao@kernel.org>
 <YgFvqnoa61BspqmW@google.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <YgFvqnoa61BspqmW@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/2/8 3:14, Jaegeuk Kim wrote:
> On 02/07, Chao Yu wrote:
>> During checkpoint, we have committed preflush command via f2fs_flush_device_cache()
> 
>   787 int f2fs_flush_device_cache(struct f2fs_sb_info *sbi)
>   788 {
>   789         int ret = 0, i;
>   790
>   791         if (!f2fs_is_multi_device(sbi))
>   792                 return 0;
> 
> Seems a wrong assumption.

Oh, I missed that f2fs_flush_device_cache was introduced to flush devices except
first device when multi-device feature is on.

	for (i = 1; i < sbi->s_ndevs; i++) {
		int count = DEFAULT_RETRY_IO_COUNT;

So, this patch seems wrong...

Instead, below case looks wrong since it needs to trigger flush during checkpoint()
no matter nobarrier is on or off.

	if (test_opt(sbi, NOBARRIER))
		return 0;

Thanks,

> 
>> to persist all metadata pages except last #2 CP pack page, so we don't need to
>> commit another preflush command in commit_checkpoint(), remove it to avoid unneeded
>> write cache overhead.
>>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>   fs/f2fs/data.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
>> index 8c417864c66a..15ac18bbbc8e 100644
>> --- a/fs/f2fs/data.c
>> +++ b/fs/f2fs/data.c
>> @@ -598,7 +598,7 @@ static void __f2fs_submit_merged_write(struct f2fs_sb_info *sbi,
>>   		io->fio.op = REQ_OP_WRITE;
>>   		io->fio.op_flags = REQ_META | REQ_PRIO | REQ_SYNC;
>>   		if (!test_opt(sbi, NOBARRIER))
>> -			io->fio.op_flags |= REQ_PREFLUSH | REQ_FUA;
>> +			io->fio.op_flags |= REQ_FUA;
>>   	}
>>   	__submit_merged_bio(io);
>>   	up_write(&io->io_rwsem);
>> -- 
>> 2.32.0