Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1f27fa76-49b9-6b53-de71-d72d076bb745@gmail.com>
Date:   Mon, 7 Feb 2022 22:43:03 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Content-Language: en-US
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [BUG] net: ti: possible deadlock in cpts_ptp_gettimeex() and
 cpts_overflow_check()
To:     davem@davemloft.net, kuba@kernel.org, grygorii.strashko@ti.com,
        vladimir.oltean@nxp.com, vigneshr@ti.com, yangyingliang@huawei.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello,

My static analysis tool reports a possible deadlock in the ti driver in 
Linux 5.16:

cpts_ptp_gettimeex()
   mutex_lock(&cpts->ptp_clk_mutex); --> Line 260 (Lock A)
   cpts_update_cur_time()
     wait_for_completion_timeout(&cpts->ts_push_complete, HZ); --> Line 
210 (Wait X)

cpts_overflow_check()
   mutex_lock(&cpts->ptp_clk_mutex); --> Line 411 (Lock A)
   cpts_update_cur_time()
     cpts_fifo_read()
       complete(&cpts->ts_push_complete); --> Line 142 (Wake X)

When cpts_ptp_gettimeex() is executed, "Wait X" is performed by holding 
"Lock A". If cpts_overflow_check() is executed at this time, "Wake X" 
cannot be performed to wake up "Wait X" in cpts_ptp_gettimeex(), because 
"Lock A" has been already hold by cpts_ptp_gettimeex(), causing a 
possible deadlock.
I find that "Wait X" is performed with a timeout, to relieve the 
possible deadlock; but I think this timeout can cause inefficient execution.

I am not quite sure whether this possible problem is real and how to fix 
it if it is real.
Any feedback would be appreciated, thanks :)


Best wishes,
Jia-Ju Bai