Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9f12a0f2-ab42-c7fc-b3b8-e6babfd7dc59@amd.com>
Date:   Tue, 8 Feb 2022 08:23:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
Content-Language: en-US
To:     zhanglianjie <zhanglianjie@uniontech.com>
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>, Xinhui.Pan@amd.com,
        Alex Deucher <alexander.deucher@amd.com>
References: <20220208031454.24232-1-zhanglianjie@uniontech.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220208031454.24232-1-zhanglianjie@uniontech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmZKbVVlaEJzK05ZdkhmcDRVdG1vL3l1VGdsYW0rOEZ3WFdhMmo1a1RISVor?=
 =?utf-8?B?R2RsM0NNN0hGbjBCS2t6YnNTdWliQjErMHdpbmFJeGNyL1k1R0JHUEp6dVEx?=
 =?utf-8?B?VWZXek94OTZ2a3ZwNTQ2dHBld09tNGJKQlc0c251eWdJOGkzWWtyZEkwelVD?=
 =?utf-8?B?cVIvK1BvdmV6R3BNTWtIc1ZDUXdrcDljM3RKU1dPME5oaE5iU2gvVkJVQ1pS?=
 =?utf-8?B?RmwwM1VxWEhZK0tBWC8wWjU0K3VqdjJEZ1pOWEcwM3JYeWhLTGVhbXFDWnNu?=
 =?utf-8?B?clZtWUJ3aFIxZis3aElmSUV3TzV0RWZBZFk4N0gra0Q4Wm9BMldqU20vK0g0?=
 =?utf-8?B?cXNMay9xK3dmZENKa3QrVG1tK0Y3TE5QejM5UGNDeXRPcHZVT2MrVzZSQUxs?=
 =?utf-8?B?N1JRenlkTzBHQ0Yvc0dIL1NiZUVKTGd5Ky93bXpNb0cvSm5reWZmcWFva094?=
 =?utf-8?B?TXJYRzlQVDNCeXFIZVNma0xkc0dyQnBPU3hrMGcrRFRLS0ltTGg4d1F1MFU2?=
 =?utf-8?B?cXVIaXRKeUJ5Zlp2YnZ5QnRnbGg3TTA2MmF1NmV0NzNsaGRSTC8xTXl5VXhy?=
 =?utf-8?B?Qlk3UWRZS2JrN1FnYkw3eW51ZTU2UHpzVllyRGtLNE5WZ2ZSRktONVBwQjZ1?=
 =?utf-8?B?SlIyOUxjbGs0QjlXSisrdzVhTWdkYVQrdUpMQzlDR25tZ2ZWSVpYU2F0bzcr?=
 =?utf-8?B?cktsUzIycmhRV29OcHc5dWdxSWVIN1lJM01naUdQODZFN1Q2eEhaa2dRTHFJ?=
 =?utf-8?B?c1NpYzRaL0x5U0FXL0o5elF0RXFoNnhESklnSVgzN0RLMjN3ZWVKbXF5WjhK?=
 =?utf-8?B?MXF5VHgzaG52L0psZk1rRkdoMVRjb29Icmo3eVVmWklHVURDL3BOSTVkWlBW?=
 =?utf-8?B?Z1U5bTFKTWY2dVFVak44cTcvTTZyRjNEMTFpT2RhNWJrbXd0akZ3NURTdnUw?=
 =?utf-8?B?QUg3QzlZWTd2elVhcm1sMHNaaUFHT3dONkhaQ0txeXdIdVJZV0RFclBsdStC?=
 =?utf-8?B?N2RwRC9wMjRXU0UvanA0U1RMcWN3ZlliVVhuWWl2WTUyMGxaRS9tTTdYKzht?=
 =?utf-8?B?U0srZmJhSjRiY0VLSkQ3SHJTMGx6YTBIK2MxdGlYZ0Q4by9Tcjc2N2F0bS9P?=
 =?utf-8?B?S0t0OFVoL3gvRG8xL21WbTBmNmdZQm10YjZXb3hFaUt5MVc3ZzJMUVpYb2dI?=
 =?utf-8?B?aUMxenQ5alR4QklYVlVxQnR3VnRYNmZPWDJNUno4dG96QkZnamlrNzdOUnd1?=
 =?utf-8?B?MWdjVDcwbTdRMzYvNTJDdnl4d2MxZUJFbVpmelZEeTFwSVJsMFNENE9WZU1j?=
 =?utf-8?B?djRRTkxOZU40eERUL0hUQ2hHWStBbVBZam9kMFZnL3RyVEZMK3hlTDZpR2FW?=
 =?utf-8?B?NnQrTTJleXl5ZDFEaS9nTndYN003Ym1YUjczVnhoZXE1ekxqWk5qTHZzcUFx?=
 =?utf-8?B?ZDBMZzl2YlJkbjVlcFFjUk9UQkFBWWs2ZDR0c29MMGFGYTlPbkxWZDdsdGNW?=
 =?utf-8?B?RS9qV3VYQzExSUlsWDdwcExySWk2V0xWRWhpdFk1VmxlK2lTS1ZrcElkWXJv?=
 =?utf-8?B?dkgwbDk4MWl5K2NDdlo3UHFGVytkdGVWZnYvaG84NWhiNlZJK21iZVBBWEF4?=
 =?utf-8?B?SHQ3dHBabFd5ZUFYKzdxRWhWM3E3WUhTTEZpRThRUEFQSHVSS0tKbHgvOXFY?=
 =?utf-8?B?RXhYM1I1MGprSzJieS9hNzBCcTNoZDJ2d1VocmMxUm0rUU5Nb3FnM21qdWh3?=
 =?utf-8?B?a0NpVEtUUTQ2TVNYZGY3ME0zQ09SUUx2NnVqUXVPNXNleGpublJLRTMxWG1r?=
 =?utf-8?B?N09sVmE4NFVDMFlLdXNleDQwNTRwaHVreGlFR2d6RldTaXhUcFlOZ3FPbkNk?=
 =?utf-8?B?Vkh5UzI2ZGx2MzA4Z2ZaK2Z4SkhWYWtzK21sMUc5bkJMSjRtbGtXL3BlTUxh?=
 =?utf-8?B?QmQ0cUNDeU1QZkhXa2RCL0pMSk5rUGlVRHUyYzk2Si90bXIycmtZcSt6bDY0?=
 =?utf-8?B?UE0yRVZNc3l6TFVJRTc0dW4wbG9NNWw3bVNuRnh4NlhlWDB4dVdpOElCSDEv?=
 =?utf-8?B?clNid0NVYUcxVGFyRGYwTFByQllTdUg2WlZvbE95aWJIUklvMldXTUxvVkcz?=
 =?utf-8?B?Y3dsZkxxZXFGRzlIZnRYNGpadUpURXFTY2JoVk1RUHNtZGdlZzFmQUlJZFl0?=
 =?utf-8?Q?N/vRQMBVKVkYUy64RVE4GDw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7add190-62c0-400e-c229-08d9ead3f2e3
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 07:23:48.6147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5tMduriutT7JSfTAfU4byu1RCLCudnlDY4TomDLNDntCWAF6BrMMt3JhFpeNJvks
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4571
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 08.02.22 um 04:14 schrieb zhanglianjie:
> after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns.
>
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

>
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index 377f9cdb5b53..0558d928d98d 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
>   	handle = msg[2];
>
>   	if (handle == 0) {
> +		radeon_bo_kunmap(bo);
>   		DRM_ERROR("Invalid UVD handle!\n");
>   		return -EINVAL;
>   	}
> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
>   		return 0;
>
>   	default:
> -
>   		DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> -		return -EINVAL;
>   	}
>
> -	BUG();
> +	radeon_bo_kunmap(bo);
>   	return -EINVAL;
>   }
>
> --
> 2.20.1
>
>
>