Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Feb 2022 10:05:03 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Shuah Khan <shuah@kernel.org>, rcu@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcutorture: Add missing - to `--do-allmodconfig` in usage
Message-ID: <20220208180503.GR4285@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20220208105240.43600-1-pmenzel@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220208105240.43600-1-pmenzel@molgen.mpg.de>
Precedence: bulk

On Tue, Feb 08, 2022 at 11:52:40AM +0100, Paul Menzel wrote:
> The usage currently lists `--doallmodconfig`, resulting in:
> 
>     $ tools/testing/selftests/rcutorture/bin/torture.sh --doallmodconfig
>     Unknown argument --doallmodconfig
>     […]
> 
> Add the missing dash for `--do-allmodconfig`.
> 
> Fixes: a115a775a8d5 ("torture: Add "make allmodconfig" to torture.sh")
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Good eyes, thank you!

I will add your Reported-by and your Fixes line (with attribution) to
this commit in -rcu:

dbc3fa1ffb4b ("torture: Make torture.sh help message match reality")

							Thanx, Paul

> ---
>  tools/testing/selftests/rcutorture/bin/torture.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/rcutorture/bin/torture.sh b/tools/testing/selftests/rcutorture/bin/torture.sh
> index eae88aacca2a..3adcc83dd55d 100755
> --- a/tools/testing/selftests/rcutorture/bin/torture.sh
> +++ b/tools/testing/selftests/rcutorture/bin/torture.sh
> @@ -72,7 +72,7 @@ usage () {
>  	echo "       --configs-locktorture \"config-file list w/ repeat factor (10*LOCK01)\""
>  	echo "       --configs-scftorture \"config-file list w/ repeat factor (2*CFLIST)\""
>  	echo "       --doall"
> -	echo "       --doallmodconfig / --do-no-allmodconfig"
> +	echo "       --do-allmodconfig / --do-no-allmodconfig"
>  	echo "       --do-clocksourcewd / --do-no-clocksourcewd"
>  	echo "       --do-kasan / --do-no-kasan"
>  	echo "       --do-kcsan / --do-no-kcsan"
> -- 
> 2.34.1
>