Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Jan Kara" <jack@suse.cz>
Cc:     "Colin Ian King" <colin.i.king@gmail.com>,
        "Jan Kara" <jack@suse.com>,
        "Stephen Rothwell" <sfr@canb.auug.org.au>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ext2: remove unused pointer bdi
In-reply-to: <20220207144612.zdczs7wxzbuk3ydr@quack3.lan>
References: <20220207134039.337197-1-colin.i.king@gmail.com>,
 <20220207144612.zdczs7wxzbuk3ydr@quack3.lan>
Date:   Tue, 08 Feb 2022 07:52:58 +1100
Message-id: <164426717877.27779.5211639626156510807@noble.neil.brown.name>
Precedence: bulk

On Tue, 08 Feb 2022, Jan Kara wrote:
> On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> > The call to bdi_congested has been removed and so the bdi pointer
> > is no longer required. Remove it.
> >=20
> > Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() an=
d related functions")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>=20
> I guess this change is in mm tree? So probably it is best if Andrew picks
> it up.

I have to refresh the whole series - hopefully later this week.  I'll
make sure to fix this bit.

Thanks,
NeilBrown


>=20
> 								Honza
>=20
> > ---
> >  fs/ext2/ialloc.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >=20
> > diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> > index d632764da240..998dd2ac8008 100644
> > --- a/fs/ext2/ialloc.c
> > +++ b/fs/ext2/ialloc.c
> > @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
> >  	unsigned long offset;
> >  	unsigned long block;
> >  	struct ext2_group_desc * gdp;
> > -	struct backing_dev_info *bdi;
> > -
> > -	bdi =3D inode_to_bdi(inode);
> > =20
> >  	block_group =3D (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
> >  	gdp =3D ext2_get_group_desc(inode->i_sb, block_group, NULL);
> > --=20
> > 2.34.1
> >=20
> --=20
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>=20
>=20