Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1644213481-20321-1-git-send-email-hammerh0314@gmail.com>
 <1644213481-20321-3-git-send-email-hammerh0314@gmail.com> <YgDHwgg0s6U3bFxF@kroah.com>
In-Reply-To: <YgDHwgg0s6U3bFxF@kroah.com>
From:   hammer hsieh <hammerh0314@gmail.com>
Date:   Mon, 7 Feb 2022 19:28:13 +0800
Message-ID: <CAOX-t55sbxd6rvkafnw-m1nYMuEZTsKOkBBftqSoKxocxSZbJQ@mail.gmail.com>
Subject: Re: [PATCH v7 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     robh+dt@kernel.org, linux-serial@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Slaby <jirislaby@kernel.org>, p.zabel@pengutronix.de,
        wells.lu@sunplus.com, "hammer.hsieh" <hammer.hsieh@sunplus.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Greg KH <gregkh@linuxfoundation.org> =E6=96=BC 2022=E5=B9=B42=E6=9C=887=E6=
=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=883:18=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, Feb 07, 2022 at 01:58:01PM +0800, Hammer Hsieh wrote:
> > Add Sunplus SoC UART Driver
> >
>
> We need more of a changelog comment here please.  Describe the hardware,
> what the new tty name you are using, and other stuff.  Be descriptive.
>

I will describe as below.
Add Sunplus SoC UART Driver.
SP7021 UART block contains 5 UARTs.
There are UART0~4 that supported in SP7021, the features list as below.
Support Full-duplex communication.
Support data packet length configurable.
Support stop bit number configurable.
Support force break condition.
Support baud rate configurable.
Support error detection and report.
Support RXD Noise Rejection Vote configurable.

UART0 pinout only support TX/RX two pins.
UART1 to UART4 pinout support TX/RX/CTS/RTS four pins.
Normally UART0 used for kernel console, also can be used for normal uart.
Command line set "console=3DttySUP0,115200", SUP means Sunplus Uart Port.
UART driver probe will create path named "/dev/ttySUPx".

https://sunplus.atlassian.net/wiki/spaces/doc/pages/1873412290/13.+Universa=
l+Asynchronous+Receiver+Transmitter+UART

> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -274,4 +274,7 @@
> >  /* Freescale LINFlexD UART */
> >  #define PORT_LINFLEXUART     122
> >
> > +/* Sunplus UART */
> > +#define PORT_SUNPLUS 123
>
> Why is this needed?  Are you going to require this in some userspace
> code?  If not, please do not add it.
>

In serial_core.c (line 3014) uart_add_one_port( )
It will call uart_configure_port( ).
In my uart driver probe set port->flags=3DUPF_BOOT_AUTOCONF.
I try to remove port define and remove  sunplus_config_port( )
 and just add a "sunplus_uart" for in sunplus_type( ).
And my uart console not work with PuTTY tool.

I try to do another test as below.
static const char *sunplus_type(struct uart_port *port)
{
        return "sunplus_uart";
}
static void sunplus_config_port(struct uart_port *port, int type)
{
        if (type & UART_CONFIG_TYPE)
                port->type =3D "sunplus_uart"; //type define is unsigned in=
t
}
Uart console works, but port->type should be unsigned int , not string.
So compile will warning " assignment makes integer from pointer
without a cast [-Wint-conversion]".

I think I should keep the current submit code.

> thanks,
>
> greg k-h