Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 7 Feb 2022 14:31:11 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Cc:     gregkh@linuxfoundation.org, joe@perches.com, kitakar@gmail.com,
        laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        mchehab@kernel.org, sakari.ailus@linux.intel.com,
        tomi.valkeinen@ideasonboard.com, dan.carpenter@oracle.com
Subject: Re: [PATCH] staging: media: atomisp: Use GENMASK instead of manual
 masking
Message-ID: <YgERD7JdlqdaNHuA@smile.fi.intel.com>
References: <20220206185830.39360-1-mosescb.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220206185830.39360-1-mosescb.dev@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sun, Feb 06, 2022 at 07:58:30PM +0100, Moses Christopher Bollavarapu wrote:
> There is a GENMASK macro available in linux/bits.h, for masking.
> 
> Example: GENMASK(3, 0) = 0b00001111 (same as (1 << 4) - 1)

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> index 1173be0e72b0..a345fa1d7de9 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> @@ -40,6 +40,7 @@
>  
>  #include <linux/io.h>
>  #include <linux/pm_runtime.h>

> +#include <linux/bits.h>

Probably this can be still ordered.

>  /* Assume max number of ACC stages */
>  #define MAX_ACC_STAGES	20
> @@ -1913,11 +1914,11 @@ void atomisp_css_input_set_mode(struct atomisp_sub_device *asd,
>  			    &asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_config;
>  		s_config->mode = IA_CSS_INPUT_MODE_TPG;
>  		s_config->source.tpg.mode = IA_CSS_TPG_MODE_CHECKERBOARD;
> -		s_config->source.tpg.x_mask = (1 << 4) - 1;
> +		s_config->source.tpg.x_mask = GENMASK(3, 0);
>  		s_config->source.tpg.x_delta = -2;
> -		s_config->source.tpg.y_mask = (1 << 4) - 1;
> +		s_config->source.tpg.y_mask = GENMASK(3, 0);
>  		s_config->source.tpg.y_delta = 3;
> -		s_config->source.tpg.xy_mask = (1 << 8) - 1;
> +		s_config->source.tpg.xy_mask = GENMASK(7, 0);
>  		return;
>  	}
>  
> -- 
> 2.30.2
> 

-- 
With Best Regards,
Andy Shevchenko