Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1559603pxb; Tue, 8 Feb 2022 22:17:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwx/Enqpc0knkOuatU2OJeeF9Zgk0g4IhfiFPg5lKoZfvVJEANjcmffumBa4ZcmJmGqxyPn X-Received: by 2002:a17:902:bb83:: with SMTP id m3mr754481pls.114.1644387448913; Tue, 08 Feb 2022 22:17:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644387448; cv=none; d=google.com; s=arc-20160816; b=QdEA3XObrroyQdyHFAAjfVSMrP0Sx+NgPt/X2r+zR7nBvsEovBPmndbEyZkdrgy1Kd LxeI2iaTm6R7vrETxuLaWCag77+Xz7Jrh0LwjG77O7Gq41BKHl6aaBK7WiungHr4F/bF Zf5SmPGwH2g2ksbXnFZmgcxy8kHGEbvl3Y+aONQA4/hM3GILp7kLS4m2bFvsHGum8hYm +OMG4GKQnLE0KbaxVBz4Bc4a5i28Oj9dvGs8hdye+lUJ6pjGs8AYU+QTFJG8nGMJRSrb 3dmwR27DEUdgeYjb6lWFT226X1Il6H23I5gg9IQNLNFw8K6LxMlsaw9PXYQh0TWKuite XdYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=B95ImHqfJQ7P50p672+AINZXWEHYD0wo35wzbPuAB+s=; b=QNm/w/rUFJ2l2BtvppFWWZGx1Lyl8I5tP4yEp6sSEpj2E7xs9U0cSnbZ2LStCycnBe Cs5r2ZD2grqkv2+FWEPhlfVutx6mUkpXs0tFWQBX096lQcohzNHtjWEtbnRbxSi5GFvY nSgfcmLipmkmdDkn1p789p2JP0zTeVGUF+H1HlGonHdT3oGHLYCNKNhg3s8yvoTSIVhv JQGgH5Jrz5nun7/Vr6WlWBgyoUIC3c3GCYfVgdXHiQ7DfvTD8++7mOQ3sDqUZuC8DNvS FW/D/+Ez1EjhZktoJwz7Os4byk69GibRwYjiJ7r8BIKwrBQcG2fWxgwZFILxwdpwJbOA u3VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bfT6YvD9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h63si14627127pge.398.2022.02.08.22.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 22:17:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bfT6YvD9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E9994E00FEC0; Tue, 8 Feb 2022 21:59:14 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238302AbiBGSbj (ORCPT + 99 others); Mon, 7 Feb 2022 13:31:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235959AbiBGSat (ORCPT ); Mon, 7 Feb 2022 13:30:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF1CC0401D9; Mon, 7 Feb 2022 10:30:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DC2160F62; Mon, 7 Feb 2022 18:30:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC0F2C004E1; Mon, 7 Feb 2022 18:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644258648; bh=riWJPhQ/S3PZiHj8yuELdnUzcOi2A/0/xMXt32fuyfU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bfT6YvD9jl0aO/52ZQpQlDFoHIG9ICGqozhjlUv6K+hT3JK6Sc3B22XwzO2T80AqS yhsCkFdBtgFcMdGGLvFrgYAX0X2hyDK28e2eX2dcaM1Fd4/auuLve9f30A5OyFd6Yn +c0Q6q8XyGnUrxvkwgKZjErBgjLQu/7LPeSzip0QrwkKANYbXfQueFkR2Td3s5ZNT/ 6hDRiQKX/YGf+jTah0gcIdsOdBcWqzjgcYNrY5TyRF0aCGRtsvG8qjGmUBEPHWsPZV +niPmkNmc1Eliih78yCfwxGdiDO1R/pzipvpcwKKOsJTrYESn8L6nax+e7+lM0J2/t I33AIqRs8zOkQ== Date: Mon, 7 Feb 2022 12:30:46 -0600 From: Bjorn Helgaas To: Bharat Kumar Gogada Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, bhelgaas@google.com, michals@xilinx.com Subject: Re: [PATCH 2/2] PCI: xilinx-cpm: Add support for Versal CPM5 Root Port driver Message-ID: <20220207183046.GA408682@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207041250.1658-4-bharat.kumar.gogada@xilinx.com> X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In subject, possibly: PCI: xilinx-cpm: Add Versal CPM5 Root Port support since you're adding support for a *device*, not for a *driver*. On Mon, Feb 07, 2022 at 09:42:50AM +0530, Bharat Kumar Gogada wrote: > Xilinx Versal Premium series has CPM5 block which supports Root port > functioning at Gen5 speed. > Xilinx Versal CPM5 has few changes with existing CPM block. > - CPM5 has dedicated register space for control and status registers. > - CPM5 legacy interrupt handling needs additional register bit > to enable and handle legacy interrupts. s/Root port/Root Port/ to be consistent. Add blank line between paragraphs. Bjorn