Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 7 Feb 2022 19:51:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Sanjay R Mehta <sanju.mehta@amd.com>,
        Vinod Koul <vkoul@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: ptdma: Fix the error handling path in
 pt_core_init()
Message-ID: <20220207165117.GH1951@kadam>
References: <41a963a35173f89c874f5c44df5530dc09fea8da.1644044244.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41a963a35173f89c874f5c44df5530dc09fea8da.1644044244.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?92fgW7zpezzUJfz50dVv0q8dJ5lCjEq3aqWaMSxfXCZO5CkIZI/6D9e8mDD7?=
 =?us-ascii?Q?/oKS5WPTOkjjbAinzmhLSMezSXmzKEVNsnoCb9jLkTJKhx0+B5i6zp6jUgXa?=
 =?us-ascii?Q?DrdDN0749qHuyVL0BVtiZCOeQfZEelelTFObxHouizvkg5wRbgEogaSoNbWk?=
 =?us-ascii?Q?1NC/XlsjSE7NVOrLvoCSin9b4I/Fpfw7hVdP/k2WYOpv/2hV+yiBGfgOCkCt?=
 =?us-ascii?Q?sbhmMpX5bIQVEWLz+GcskwvPzbV592hwzoMWw3kPA+Itx4I5uYYsdG6mnVIf?=
 =?us-ascii?Q?R26o4jT3oHSNzphjsglVB+50HZrP+fJXYdVyFeXv/StwOLTOXjuLbFZ9QjdG?=
 =?us-ascii?Q?olHAP3unhSLoNInX5HbTpzLYDfIntpVmAdt7ois0AOYyIvBvn2E2zQe9RVcX?=
 =?us-ascii?Q?p/1VHKjKL3NCXVTt0v2zXzlpl3XCMyHOwHB55v8ym8QO8oSTlLpyujHLliT1?=
 =?us-ascii?Q?ud/y2v6vtnXk9YJQh9IaeIBbLLcoxRETH+cwE3Ugteu//zMAWp86bPqKGdI0?=
 =?us-ascii?Q?CxLmYQ2qgdW7TJj7xpW042BUY/squloPQcuW/D4qgkZIkHkvqoF0YcKCoQBV?=
 =?us-ascii?Q?23C4oo4ohjXHqThqLw4DbM4t7I+I/C4D202BViT6bI2ugM630CacjtQMTyyZ?=
 =?us-ascii?Q?j/eUtF9dTlaJn1rJJIDDsGwlB9qZ3stbMw3FF4orUnjv68fl+L97Bw8nF7KR?=
 =?us-ascii?Q?Yg+SACvdhcEg6HFDoOfCHUSgBQsqlHcZofvo1W2sbto7v5Z+x43jhlrbVxzl?=
 =?us-ascii?Q?J7vgh+RV3dU8J95XfBF40aompOMqpHgmje2RaavRmicV8bAvHpYRbmyaHmak?=
 =?us-ascii?Q?tMxQQJjJrY9xCBlO7Dogkl7bI2cUOor0as2s4XBVB0vHIupuFjJVUzsRXKpG?=
 =?us-ascii?Q?M6HLp75j6uBCWf9bt6i/pwu+jpUGwr6nYn7B18NPDA2+dQIHdedcRHrrZR8D?=
 =?us-ascii?Q?9qb88BLK5bLxz6HlRwXnOyh/O7Wbl03P1GG826dcwEGzgaw5ZycVfnzR9KNr?=
 =?us-ascii?Q?qW6nKBHZRH3ZeHEcm9PEKQAjMr+u5HcPGs56Ad7COBXhoXcOFPUsYO0NBkzX?=
 =?us-ascii?Q?7We9Y71zkytzkAuSXMyk7ogdOy8izvAxlbZt4mMh6A9T3hvme+MFoVumGri1?=
 =?us-ascii?Q?EV9TjGdcIDCMNN3d3ZmwwuDDAaXl4qd0r/OgPw3IE5owBPIWACijGZ6yJOK2?=
 =?us-ascii?Q?8Fn2+6PfrVayVcAM6DFjCzev25dCf/8neRtgBAKPdEIxXL95WC4jJTYKOVT9?=
 =?us-ascii?Q?vxG2uEvY9MlzcDcCwmCqA1njXOWBn69q8lNy4JNmiMRXPg+kVTwHIROKWTsn?=
 =?us-ascii?Q?aeL1NdzFhwfRLxePoQHd8bwOcIRiktin0reAbajbtu/+U8Up5H/rxiFf+fTh?=
 =?us-ascii?Q?ZYjG5gZ/SRquLCCRQCddzufSz9t3XntxAiN6MkcsU0jpsDWiUAERodNk5kKw?=
 =?us-ascii?Q?X72JGszT5X8EgTYrivuCmQPF0d8KoKGHNfSmJYyfXxsv+bqcLuMt2OIxdpd8?=
 =?us-ascii?Q?3F7tHBWRvEvut4sEdVLBFq/QtUp3NYJF8AmpoW9eNVzoSg/UBi4QRkj2i7Os?=
 =?us-ascii?Q?EhMbzwYGvavBg6kFgChrH/qOYQpKCcZSLzHymZbG/6DFohJnlCSTfRiTDTY9?=
 =?us-ascii?Q?Ik7iN15mbldEBXvVR7Hg2mBfQ3lBsDyPL3lcCUdBqcOMtY4grbRa9DxFeD3t?=
 =?us-ascii?Q?T6Q+pw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60964233-7065-464a-450d-08d9ea5a2503
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:51:54.3719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OE4y7XTf8qnYCC+GbLct1ctTLraoDqTDn5TDTSeCxzgiFKlbIREoBIfvLRfV+gl5pMR8Z0LI3+/t7TAu62IaLWUBGdklGCEwxkye5eeCdX0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4467
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10251 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202070104
X-Proofpoint-GUID: HoaerdAjmfyZF1BCiZtJvG6-_o3FvM4W
X-Proofpoint-ORIG-GUID: HoaerdAjmfyZF1BCiZtJvG6-_o3FvM4W
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 05, 2022 at 07:58:44AM +0100, Christophe JAILLET wrote:
> In order to free resources correctly in the error handling path of
> pt_core_init(), 2 goto's have to be switched. Otherwise, some resources
> will leak and we will try to release things that have not been allocated
> yet.
> 
> Also move a dev_err() to a place where it is more meaningful.
> 
> Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> v2: update label names
>     move dev_err(dev, "unable to allocate an IRQ\n");

Awesome.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter