Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Topic: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats
Thread-Index: AQHYHKbq8GXukjoutEaxquFuvaFzqayJwKKAgAAI4IA=
Date:   Tue, 8 Feb 2022 15:34:49 +0000
Message-ID: <20220208153449.wyv7xrv4kotji7mb@skbuf>
References: <20220208044644.359951-1-colin.foster@in-advantage.com>
 <20220208044644.359951-4-colin.foster@in-advantage.com>
 <20220208150303.afoabx742j4ijry7@skbuf>
In-Reply-To: <20220208150303.afoabx742j4ijry7@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LTFF03lu1BowvRL61AhSpx9diqTAFbK0VjH65/n9xxL14o7s80DjizwwHVFs?=
 =?us-ascii?Q?1vzFP4Jr+9Xtg5lk5DJ6SAQOkAy7g9a3w5re8iW2RE7UOH9Qq2Ab/olVfS8D?=
 =?us-ascii?Q?U+dB/RkiS9j5MiXz9Xrt0mFpfBaEWXCp9pmWIFAa6wJp44z5X9F3omp4CI/W?=
 =?us-ascii?Q?W6vKtSZrMyYqSiTtluMIZbxRrjo3jl+Z1IHPkYGmkpWGfDvaZdgBgp9D4eUH?=
 =?us-ascii?Q?RxbIW7G92fxncaNI1JrBb6n50xgHbqNTjZa2kscZBlanQsUEaI2qiEDfiwg2?=
 =?us-ascii?Q?zFeq3SmW+6ETUah3XFHFmH5blFLTiFYf+oSBcXSBBsyLngTyKL554uY0Kw4n?=
 =?us-ascii?Q?CANDlYZBY0+LRW9kMWLgswJrlKfjNjO/DmTocetQ5oSF3imM7Jo/oChn6qyb?=
 =?us-ascii?Q?l2+tife8mfRQfQ/vXa7wZRhdOyM5sYortyaghBN8+yPEXubXWRsHm3YNVLdO?=
 =?us-ascii?Q?VJzJb4qBJ5X75et1XcSlgb9nE+Zppxvug2hhqWmNiIUR3j28128rxAcRhCmt?=
 =?us-ascii?Q?4yDTxt4+w/fynSjFul0K8STpVVJrGZY6GcYuLYY4ZUaXUTL0o8WYvh84SrTj?=
 =?us-ascii?Q?/8x8eOSCIqwsovZ6DR/+kerglfMC7//nGk+gIfJL9kRC2aCDULKcZm48Pcav?=
 =?us-ascii?Q?rYYfqBGN8vOgxEbVB9Q12sHObw620w+NhvKZTRYkwax6rbyRMo5uIMWun+wM?=
 =?us-ascii?Q?1dBaxSSo5bhZxMgf+44qAAIfB/l4QmQluR1Iw30Ca83AlBUhkBd6vZzbwYj2?=
 =?us-ascii?Q?7ROc21bsEpoOPdwzyKEVoqyaaHzOt0DY9vhOYGKLiDNQq+DQ6dtC1YzlM9ny?=
 =?us-ascii?Q?JEOo3XPMhwjW0y9SmBulLei2AaXMls84Sx7UnWjkuSKLyTKEkxPrJklz+jCP?=
 =?us-ascii?Q?4xDDDekQlemu49NFYBn4Mnd3ZnwgfZsvAJk9QTV9MSTteDuDBUvCXHiiaU0r?=
 =?us-ascii?Q?aVTKVIc6dRSS4lLkMbO+rDCyQMNne9ScqeTWqvGCfOUvdjJgG36Wzpb+DPqh?=
 =?us-ascii?Q?47BSEqTXSYaxRVFi9rX2G1kaOKTTt9WSSAvzpgfNBB5YrmGv67dHAFIn6IjH?=
 =?us-ascii?Q?6o3irA736hAUM73yevSrDrc2JOJr+4Q2KFCHSRngjQEkq2Q37Qqm+eX/pgJG?=
 =?us-ascii?Q?711C+NnOIKaYnKUXMaJVRUp9Y877vSfdkhI2uTbsQq6QBVve27s0n5mzi/hh?=
 =?us-ascii?Q?uvv4nhiGD7T8EDCKhLvK/+YT/0TId0qizxfjadgPc5sYW8x2nMwLT1Kh+Laa?=
 =?us-ascii?Q?ypE2NAl/1z7KjOicz1ywwFYQqYtGu7j4qUEx4PaW+3+sI6dr6HFJqC64nw4L?=
 =?us-ascii?Q?BVR/Y3OgVNrb/3YlY7oNuipPKiZttr47NkUf33aN1EOs5trP9TOnez1xjDJt?=
 =?us-ascii?Q?Tlsyd50u1o3LUDcqJ6nFDv9SYkvybQSOyjntuA3qt6wRtqcCPmBKy48lFI4F?=
 =?us-ascii?Q?AKw/JRuQSY6iwMvtOuqanydeABvTln751zqEcwe6+YEQz3NZ4ecmOZKhk1K0?=
 =?us-ascii?Q?u5EVmkYGRQdK4UjOD/9GgxMFnuWpi1hE0qddmcjBC253xaQG7JK6ipHiIk1g?=
 =?us-ascii?Q?Iu3QCsrD8mPEKrhdYCuK/v2H1rECrCVXRt2XeemryRpopoFQbe2Xh2Dhj0gR?=
 =?us-ascii?Q?8cAMLQlqxIcdhiN3+0QgH77YTAnmOly5owDkHJFtx3Fh?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ECCCF2D2CEDB0A45B0D9C8517A034632@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b19df91-d6bf-4613-5d42-08d9eb188b56
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 15:34:49.8133
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3W+DJuyVUwRaYlzzV4WUjFTjURVsB9MvwbPTZ4w/bGowykus9qMFyqIAbU2l10pofmoU9bSMbRJlPRFFc/ZWag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6214
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 08, 2022 at 05:03:03PM +0200, Vladimir Oltean wrote:
> >  	for (i =3D 0; i < ocelot->num_phys_ports; i++) {
> > +		unsigned int idx =3D 0;
> > +
>=20
> This is a bug which causes ocelot->stats to be overwritten with the
> statistics of port 0, for all ports. Either move the variable
> declaration and initialization with 0 in the larger scope (outside the
> "for" loop), or initialize idx with i * ocelot->num_stats.

My analysis was slightly incorrect. Somehow I managed to fool myself
into thinking that you had tested this in a limited scenario, hence the
reason you didn't notice it's not working. But apparently you didn't
test with traffic at all.

So ocelot->stats isn't overwritten with the stats of port 0 for all
ports. But rather, all ports write into the ocelot->stats space
dedicated for port 0, effectively overwriting the stats of port 0 with
the stats of the last port. And no one populates the ocelot->stats space
for ports [1 .. last]. So no port has good statistics, I don't see a
circumstance where testing could have misled you.=