Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Huang Shijie <shijie@os.amperecomputing.com>
To:     catalin.marinas@arm.com
Cc:     will@kernel.org, bhe@redhat.com, vgoyal@redhat.com,
        dyoung@redhat.com, corbet@lwn.net, kexec@lists.infradead.org,
        linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, zwang@amperecomputing.com,
        patches@amperecomputing.com, darren@os.amperecomputing.com,
        Huang Shijie <shijie@os.amperecomputing.com>
Subject: [PATCH] arm64: crash_core: Export MODULES, VMALLOC, and VMEMMAP ranges
Date:   Wed,  9 Feb 2022 09:26:42 +0000
Message-Id: <20220209092642.9181-1-shijie@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n/TsRYOfT3VPvL3gXd5ggIgh1gfUW9rBIE2afRdHSpj+zz49HcR41wE11m4p?=
 =?us-ascii?Q?2cWEehe779AH29hA2pO8l0ZfOY45vOeCBsrTWH55Oy2mb9ouENUYGYsYCZqu?=
 =?us-ascii?Q?v7Rp3LQAIKuRhQcpKR6peGPVv0JJ7RLl1soyiyhBnsnHCE4+mA/8thKjBztB?=
 =?us-ascii?Q?AUP+kQtUAHG3uNaUh4oniP8rPG9OLoudEqa4t4AMud6EgnsrG6RQuvfDYPR2?=
 =?us-ascii?Q?r29AGV9mYSIcfuVUB+vy2lsHkuAbLiIS25FFWJmY2YXpIkg/SNROiuyo2M+d?=
 =?us-ascii?Q?x/dbzjT9nTFTYmnT0DEaj5og51xr1xpGZkFy6yJ6b39eocYP8+YLKmzqmcrk?=
 =?us-ascii?Q?oN4b1v117V6o+Prce7Sb27UaJT8Ue5+FBqq0xCstB+DHyAdVoahqrXrSGQu7?=
 =?us-ascii?Q?ba68xG2IKY8L0q+lYxtZ1890+zIacfQn8dwj2w8/1bsAkSvjyTyL2Qk+O1mI?=
 =?us-ascii?Q?G62qdfkG9FoBCtdb44hg53UKZk6srDZ914WbrmrG+GBLEMrE+cpGgV2I4Dmb?=
 =?us-ascii?Q?SLO2w99Ir+uQTj25VN/uMmEhSgJZtOZrfIyFRTs5o+ai26Po72ChyKII3fmN?=
 =?us-ascii?Q?8Ke7FiY2IiqPhjEfttsgvrNjy97ngrl9NVSghouJUUFQBaLXPPMkok2nOzbE?=
 =?us-ascii?Q?Tal1BGdbrHliNPoZkPX8dL8mp4QdGqfMYpkH55pXJOVRlDFH9Gqx6i9wacGO?=
 =?us-ascii?Q?VgigAJ4SlAGn2dQ0KAyMbB/Tufzaddqu6TNUHO9LT0FPYOJUyQNdxsacTgzy?=
 =?us-ascii?Q?f2MPq3qc3k11bp8kQhoOFlcBbkOcaW5kXCDFnL1AgwPfETpbizEJXeULFKIR?=
 =?us-ascii?Q?be981dDlgEs6nqvvAMoH4dxzZow/BeceXk+R0UFkxuTK8f9otlr2BS4EzJoi?=
 =?us-ascii?Q?tFReVEPgImej8KBZkhiX7PtXZcV4doHWqbKqjsRM3j+Bh6viZ87dcKGpRsGi?=
 =?us-ascii?Q?hESLC02biLnl/4wNwaDVNJR0bNkcuVl0adkl1dFPYFyICNaw1peb9JC7KUDv?=
 =?us-ascii?Q?LeXKlWTDIqKsRlVM2xBMR/O97Bg2C2GP1aV2boL1IfCUCMdh56OgAVXnes8T?=
 =?us-ascii?Q?lE/o97eQzP6F5E3DFx8lcESWzk/Jqcxu18eL8hA7O5w6gRFT7CTRa67JFaIq?=
 =?us-ascii?Q?QLgx7BsaN0ocul7OGtkFqC9jPQmuOxEQFuxCn6Uio6Qrme5eqxsSy4M7Td/U?=
 =?us-ascii?Q?D7lc/kFfFjsy/Rn2SMDWCBu1KvZ4ERQSfWgyyAkXGQO6YBNEYZGADjJT/FNz?=
 =?us-ascii?Q?smAwaE/ZZfGIy6XKXNvVhesnPFYuUh5S75IxG2aKQS75r0qLx17ybzDfd2VB?=
 =?us-ascii?Q?wLthVg/iihdeb8e7+oskbmfUrVVsNddDhecIb6h4isPwbFr8Dt7m2ZII6vAa?=
 =?us-ascii?Q?Bd9BJ3Y25o6H+bKWjKtsNEYZtzGb1gOUgusjN49peUhvLUVhilxM7//8lEPL?=
 =?us-ascii?Q?aiuXYZfggVZ2/mMNsPTZ22xBBmyXmXehXMZaIM290ykRR9AcPyDMTbOnBCvd?=
 =?us-ascii?Q?7mRNvcgfc8uzvlb3v5zGexLpuuFlcvyeKCJkDN2sQgj8PtJwBTVzKxvS+AWZ?=
 =?us-ascii?Q?RDrS13kbXQfkPP6t5/L0JSb5r5xXTOrul0gPxjMSG0t3roCQWfHLajJmiTnj?=
 =?us-ascii?Q?PUMiwN3nzxA72jxEYT//NxSJLkzBNnx1CYBA+8FLggJtz13bNPjonqSFzp4e?=
 =?us-ascii?Q?xP02j1hZrW1Ou0sZL4aUccLtTtxUCV4DDobdPMjG2tyhY5++K/hE8G+McOyw?=
 =?us-ascii?Q?xwoL9uTZeQ=3D=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a13b40ca-effa-400f-ddab-08d9eb6bad80
X-MS-Exchange-CrossTenant-AuthSource: DM8PR01MB6824.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 01:29:56.2378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xnZezGtEH7ybg9z0LwQRXNmZE9AIskkiQBJAex5krRy4ud+zHkOBXbJIvscua3jTzfZNUeCRUXwRxIUGjxv0t2/Bme01x1mQ0g68WgjkcGOYYgC5FWEvNnnG2X/o3bbw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB7355
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The following interrelated ranges are needed by the kdump crash tool:
	MODULES_VADDR ~ MODULES_END,
	VMALLOC_START ~ VMALLOC_END,
	VMEMMAP_START ~ VMEMMAP_END

Since these values change from time to time, it is preferable to export
them via vmcoreinfo than to change the crash's code frequently.

Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
---
 Documentation/admin-guide/kdump/vmcoreinfo.rst | 8 ++++++++
 arch/arm64/kernel/crash_core.c                 | 6 ++++++
 2 files changed, 14 insertions(+)

diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
index 3861a25faae1..a339af45a22e 100644
--- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
+++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
@@ -494,6 +494,14 @@ architecture which is used to lookup the page-tables for the Virtual
 addresses in the higher VA range (refer to ARMv8 ARM document for
 more details).
 
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END
+-------------
+
+Used to get the correct ranges:
+	MODULES_VADDR ~ MODULES_END-1 : Kernel module space.
+	VMALLOC_START ~ VMALLOC_END-1 : vmalloc() / ioremap() space.
+	VMEMMAP_START ~ VMEMMAP_END-1 : vmemmap region, used for struct page array.
+
 arm
 ===
 
diff --git a/arch/arm64/kernel/crash_core.c b/arch/arm64/kernel/crash_core.c
index 314391a156ee..2b65aae332ce 100644
--- a/arch/arm64/kernel/crash_core.c
+++ b/arch/arm64/kernel/crash_core.c
@@ -20,6 +20,12 @@ void arch_crash_save_vmcoreinfo(void)
 {
 	VMCOREINFO_NUMBER(VA_BITS);
 	/* Please note VMCOREINFO_NUMBER() uses "%d", not "%x" */
+	vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
+	vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
 	vmcoreinfo_append_str("NUMBER(kimage_voffset)=0x%llx\n",
 						kimage_voffset);
 	vmcoreinfo_append_str("NUMBER(PHYS_OFFSET)=0x%llx\n",
-- 
2.30.2