Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 8 Feb 2022 19:53:06 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     yajun.deng@linux.dev
Cc:     davem@davemloft.net, rostedt@goodmis.org, mingo@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dev: introduce netdev_drop_inc()
Message-ID: <20220208195306.05a1760f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <753bb02bfa8c2cf5c08c63c31f193f90@linux.dev>
References: <20220208162729.41b62ae7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <20220208064318.1075849-1-yajun.deng@linux.dev>
        <753bb02bfa8c2cf5c08c63c31f193f90@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 09 Feb 2022 02:20:07 +0000 yajun.deng@linux.dev wrote:
> February 9, 2022 8:27 AM, "Jakub Kicinski" <kuba@kernel.org> wrote:
> 
> > On Tue, 8 Feb 2022 14:43:18 +0800 Yajun Deng wrote:
> >   
> >> We will use 'sudo perf record -g -a -e skb:kfree_skb' command to trace
> >> the dropped packets when dropped increase in the output of ifconfig.
> >> But there are two cases, one is only called kfree_skb(), another is
> >> increasing the dropped and called kfree_skb(). The latter is what
> >> we need. So we need to separate these two cases.
> >> 
> >> From the other side, the dropped packet came from the core network and
> >> the driver, we also need to separate these two cases.
> >> 
> >> Add netdev_drop_inc() and add a tracepoint for the core network dropped
> >> packets. use 'sudo perf record -g -a -e net:netdev_drop' and 'sudo perf
> >> script' will recored the dropped packets by the core network.
> >> 
> >> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>  
> > 
> > Have you seen the work that's being done around kfree_skb_reason()?  
> 
> Yes, I saw it. The focus of kfree_skb_reason() is trace kfree_skb() and the reason, 
> but the focus of this patch only traces this case of the dropped packet.
> 
> I don't want to trace all kfree_skb(), but I just want to trace the dropped packet.
> 
> This command 'sudo perf record -g -a -e skb:kfree_skb' would trace all kfree_skb(),
> kfree_skb() would drowned out the case of dropped packets when the samples were too large.

IIRC perf support filters, I think with -f? We can't add a tracepoint
for every combination of attributes.