Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Feb 2022 13:44:47 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzk@kernel.org>,
        'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v2] regmap-irq: Use regmap_irq_update_bits instead of
 regmap_write
Message-ID: <YgJzz5GFsKBteYyg@sirena.org.uk>
References: <20220119142953.1804-1-quic_pkumpatl@quicinc.com>
 <CGME20220208122955eucas1p2d4e32f51224242e9ebd0bce58b9c04ca@eucas1p2.samsung.com>
 <39f1b598-58ca-1e3d-3065-8dd692ee7c9f@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bGkYXeNT7w8NEyD+"
Content-Disposition: inline
In-Reply-To: <39f1b598-58ca-1e3d-3065-8dd692ee7c9f@samsung.com>
Precedence: bulk


--bGkYXeNT7w8NEyD+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 08, 2022 at 01:29:55PM +0100, Marek Szyprowski wrote:
> Hi Prasad,
>=20
> On 19.01.2022 15:29, Prasad Kumpatla wrote:
> > With the existing logic by using regmap_write() all the bits in
> > the register are being updated which is not expected. To update only the
> > interrupt raised bit and not tocuhing other bits, replace regmap_write()
> > with regmap_irq_update_bits().
> >
> > This patch is to fix the issue observed in MBHC button press/release ev=
ents.
> >
> > Fixes: 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack registers")
> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>=20
> There is something wrong with this patch. Since it landed in linux-next=
=20
> (20220204) I get an interrupt storm on two of my test devices:

I'll just revert it for now.

--bGkYXeNT7w8NEyD+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICc84ACgkQJNaLcl1U
h9Dcpwf/ZuoJ3isPhFf8jelGmKPzrCWi40feOyhm3CWL/l7usejsTkiUPR7NpV8g
QjGdxc+NJaaIcuFGf30EL7r/xZmOfw7rwEBj/tWH56YJS2xKxIRuT/T59WOHbe1c
+7geKmc8uCPErb/5J8PJWLpSurDpsqIDu3O/o6WfgF5FfIJeRjE30uhvdklEpy1o
XjMq1+8C4Bzp2FrKQLmMuEAem29GJb7FTgdMslly/MEKSXoQZtDY+ToF96flLg6w
UCx4up1xa852G9gTXvKvNqtCJvyw/fC6Fdu1EUbabDVz35yiCmLPVePtBhdzgIVl
ig8kR6VmcKsbsrze0yB1Sm4MuqdQhQ==
=RHEL
-----END PGP SIGNATURE-----

--bGkYXeNT7w8NEyD+--