Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c61a227e-e35e-55a8-3571-6e015e222d5f@intel.com>
Date:   Fri, 4 Feb 2022 16:11:14 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.1
Subject: Re: [PATCH 0/3] selftests: Remove duplicate CPUID wrappers
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>, <shuah@kernel.org>,
        <linux-kselftest@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ram Pai <linuxram@us.ibm.com>,
        Sandipan Das <sandipan@linux.ibm.com>,
        "Florian Weimer" <fweimer@redhat.com>,
        "Desnes A. Nunes do Rosario" <desnesn@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>,
        "Thiago Jung Bauermann" <bauerman@linux.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Michal Suchanek <msuchanek@suse.de>, <linux-mm@kvack.org>,
        "Chang S . Bae" <chang.seok.bae@intel.com>,
        Borislav Petkov <bp@suse.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, <x86@kernel.org>,
        Andy Lutomirski <luto@kernel.org>
References: <cover.1644000145.git.reinette.chatre@intel.com>
 <81df8c0e-fde6-f3b8-f988-b539f193635b@linuxfoundation.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <81df8c0e-fde6-f3b8-f988-b539f193635b@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U084SFhyRitXdVlvRTkwaTd4ZVh4V3ZQMDU4NDV4aEE2S3N4UXBFdU1Ub1ha?=
 =?utf-8?B?OEVGS2NPOUcwTC84Qm04RE95R2NvSk9pUmhndS9Nczd3b3dMdDdqN21xZWla?=
 =?utf-8?B?Y3R5TThZVE80c084clcrWWRXZzZDYmxWcUlsMExVZlVieTdjYXgvSHNiVlhW?=
 =?utf-8?B?SjI1YnJmckJBL2JGaUFEUW5nNzhNN1Z5VndRNXFPamp6dTQ3TEFqYkw1dVJM?=
 =?utf-8?B?aUVQWUdZUTF2b3Z1eDdsTXBabTlVVEozeGg0Ri9lUkQ1MTVyZUpTTjNaMjEz?=
 =?utf-8?B?aU9ONS8xM1NxYjBVdDE5djYwTWZqQVF6RTlNZWtyREptNlZsQ3BxM3BhWkZh?=
 =?utf-8?B?MGt5UC9lbCtSWVRkSTdhNldURXpGbGYvczlYWUx3SGhtdmlucVBFNnRIbkxm?=
 =?utf-8?B?R0w1YXBrNlpLS09PZ1ZEMStlZnZHSktyME96U2VFbWorK2VRRjJZemRhcHVI?=
 =?utf-8?B?Yk5BQWx3aDE4Sk5RcGU1K01rYzRBMEV4amRTRkQ3VHFBV3IzOWtnZkh5TzY3?=
 =?utf-8?B?VEo4MG9rK2xwZ0ZGTDhnMlBhSG5zeWtYbEw3Y1FhcGl5eUZWZDBxZTFqQzlD?=
 =?utf-8?B?ajU2VnNxQVkyVkRrTm5HYVczSnBjaUZDNFFRa3NCbEQwbTQ5a08rczdyK1JQ?=
 =?utf-8?B?bUVDNldkaFFkMjI4Zmc4ZE1MZFJML3dKWDYvY3ZleTNOeW1raHJScm1OUzR1?=
 =?utf-8?B?cjRpUGQzb3hvanhIWUhNV1B5QWhPWTVVcGJObWlid3Q3WDZraCtaSE1MZnVo?=
 =?utf-8?B?NEFWOHFLMFdHK3U5azJsR3lvUHV2ZTlQTFVEQ0lGM0NRVjU3NW13dFNsbHVh?=
 =?utf-8?B?bUhjdG14U3ZZT0hWQnhBVlBjbHRoMmpWS2hlWm9DdnB2aFZ0ZmZDVXEyV3hY?=
 =?utf-8?B?OTMzdWFsWVI5U3hPbW5ibU9ML3hFNE5Ya3RQR1ZocXlPdWZVQ3hsNktkbk1H?=
 =?utf-8?B?K0paTXQ3YjNTcmtBYWZDZzJPNXlaRnh3WG9vRHQwZ2p2bG81enNXckllb2Nz?=
 =?utf-8?B?K1BIODd6T0QxM3V3b0dZUXpyelVaQWNrTmRaazFrMGl6dmZzclg2QUgrcE1i?=
 =?utf-8?B?RnJHWUVSQjdvL0ZTRW1CSlpJa0hRSmJCMWtGNEN4MWo0czQ0dSt4YlYrMU1E?=
 =?utf-8?B?N3l0RDg5YzlHT2pwSEdHeUlMK3BYcCsySVJLczFyS2tkdHBMaE0xZngrUkQ1?=
 =?utf-8?B?cFlmbjJwOVZwVkJLTnlFSmtLcUFHZnB5dVRGZ0xGOXNkUVNENDJLNWlIRjV6?=
 =?utf-8?B?eU1nVEV3aGdOL01nMVBJTjFIZW5nQ0dFMXhGZkxsUzJGWlEyWHY4ZC9BVXRk?=
 =?utf-8?B?TUZYaXNpYjhyL2FxU28wY2dpY2JHbE9zMC92KytEUXI0aEl5RTFQWjdtZkVp?=
 =?utf-8?B?RlJycHV2eXdaS1J3VlQ4dWpEOGRwSmhyUFcwSlpiTi9hU1RKcHZ6OXBYVC9q?=
 =?utf-8?B?ZU52cmk5aDI2WjJPcXIzZ2oxeEt2MkR4MHFCMFlMTi9NQnljMStGY2hzNm9N?=
 =?utf-8?B?dDlFQjEyUmxBVWcxREllZk5XMzlQcmFwVjBEUW1NWXF3OVBwQ0hrS3pWNmtG?=
 =?utf-8?B?b0N3UFFIMmMvNk5zNFduZndOUHBxQU91UXJCd0dEZnlha3dJSXRvNzdQYlE0?=
 =?utf-8?B?cjNaLzk1OG9YZnhLWlRQZ05GN2dBUFlZTU1LbjJVeDBwSlQxT3psbHhjU3Fo?=
 =?utf-8?B?dWJFUE91NHVDdFQxaURaMDJaa3BIN25UU1MvRmpoTE4rcWtJSG9XdVJkM0I5?=
 =?utf-8?B?TTBGNUl1a1NxMENXWEpFZTBib1Z2dVlkMkRUYk5pQk40SXdpS1ZTcGhMT2Y3?=
 =?utf-8?B?N09neUJaS0NrQ3dmR3JGQ2ZuSWcyMWFGRTZuY1ppWXkxZGJxWC93bjZCLzAv?=
 =?utf-8?B?TnRPN05JV2w3SEp3Z0oxZi9rTHIvVEk3OTU5eCtXUkpnNnpyR1hpRWVaWlRk?=
 =?utf-8?B?Q09NS280djZVSktjb3JNWXgvSyswRVJobFRCTUYyZzVRbUh4aVVWS1QvSVpi?=
 =?utf-8?B?Sk5wb05XSjRlWS90MnUwTGhTTHZwWEJpd1o4U0EvK3c3VC9jaGV0NzNaOXZv?=
 =?utf-8?B?RFhweHhqVFMrL2JkWGFtVEFoK2NiT0tHckVhNjNrSXZzcXJ5NUZmckZuWTht?=
 =?utf-8?B?aVhkd2ljVDBwOXhsNzUvNzBuQUhNZVI3YWp4VkFGTnR4R2FYcXoyNzg2QWRL?=
 =?utf-8?B?SVU3c0JCN244emlaK1F6aEZkbXVEa1QzL1ljdEU3SXF6RnFmOUt4eVNaYUpu?=
 =?utf-8?B?QktJQXYwZjJBZERMNkphU0tDMFlnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 06437a82-2e22-4dce-7353-08d9e83c08dc
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 00:11:19.7107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IpY49Dre99jmE0gvFwViOP8zX6YkVNeXyWCxSq3cAAgVz2lbZEHtqSSnItTJpUAkyZO7eQN/3D2hLpPWr6g4iNpESPi81LXkkfR4hKr2P9Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4402
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shuah,

On 2/4/2022 3:39 PM, Shuah Khan wrote:
> On 2/4/22 12:17 PM, Reinette Chatre wrote:
>> A few tests that require running CPUID do so with a private
>> implementation of a wrapper for CPUID. This duplication of
>> the CPUID wrapper should be avoided but having one is also
>> unnecessary because of the existence of a macro that can
>> be used instead.
>>
>> This series replaces private CPUID wrappers with calls
>> to the __cpuid_count() macro from cpuid.h as made available
>> by gcc and clang/llvm.
>>
>> Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> Cc: Ram Pai <linuxram@us.ibm.com>
>> Cc: Sandipan Das <sandipan@linux.ibm.com>
>> Cc: Florian Weimer <fweimer@redhat.com>
>> Cc: "Desnes A. Nunes do Rosario" <desnesn@linux.vnet.ibm.com>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Michal Suchanek <msuchanek@suse.de>
>> Cc: linux-mm@kvack.org
>> Cc: Chang S. Bae <chang.seok.bae@intel.com>
>> Cc: Borislav Petkov <bp@suse.de>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: "H. Peter Anvin" <hpa@zytor.com>
>> Cc: x86@kernel.org
>> Cc: Andy Lutomirski <luto@kernel.org>
>>
>> Reinette Chatre (3):
>>    selftests/vm/pkeys: Use existing __cpuid_count() macro
>>    selftests/x86/amx: Use existing __cpuid_count() macro
>>    selftests/x86/corrupt_xstate_header: Use existing __cpuid_count()
>>      macro
>>
>>   tools/testing/selftests/vm/pkey-x86.h         | 22 +++---------------
>>   tools/testing/selftests/x86/amx.c             | 23 +++++--------------
>>   .../selftests/x86/corrupt_xstate_header.c     | 17 ++------------
>>   3 files changed, 11 insertions(+), 51 deletions(-)
>>
> 
> I am all for this cleanup. However, I am not finding __cpuid_count()
> marco on my system with gcc:
> 
> gcc --version
> gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0
> 
> My concern is regression on older gcc versions.

Please see this message from our earlier thread where you were able
to find it on your system:
https://lore.kernel.org/linux-kselftest/63293c72-55ca-9446-35eb-74aff4c8ba5d@linuxfoundation.org/

As mentioned in that thread, on my system it arrived via user space's
libgcc-dev package. This does not seem to be the first time including
files from this source - I did a quick check and from what I can tell
existing kselftest includes like stdarg.h, stdbool.h, stdatomic.h,
unwind.h, x86intrin.h ... arrive via libgcc-dev.

Reinette