Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1590479pxb; Tue, 8 Feb 2022 23:21:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyV4O3XobcvHHCHM2zaAAeJnzwSgYFVhJBFIv1X+NWJ9DsfjlIXzQm9j6cJY+QyU111SH/e X-Received: by 2002:a17:903:32c3:: with SMTP id i3mr937656plr.46.1644391268894; Tue, 08 Feb 2022 23:21:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644391268; cv=none; d=google.com; s=arc-20160816; b=b3OG6QjQAq4I5WCQp7hIJ++cMkvUgvgiNVmsCL0QluyIDs/erdsggzmYDZwL81rq6e m6QIMsthm5z82i3Qxutv0mi8+L1hBsmI1R2BmB8ccoulxfPk45wgRVRtUqTA35bQyiwE ItA1m2NepuG831hnFStbicXR+tjNhQ0IbUdP8IvZa9M4w9i0+r5s1v03bH6YoN+3SQ0u uQ0eBNV3SZbE1mHViPjcl8z+K6PK0Xm1avJY9BFtuPzQSUuMF/+ZKERMqVKVh9xOikia 1X6SSzfsWL1WaHiNOKJJh2crSbWPuH6V64OzMEOej+PP6euv053b6XzhNMkJGrFpvgcD +fog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZCBQfIgsaaqGa9NdTBKby2K4luKCO2x9ltO+P32Dy1E=; b=xB09wFfH6IOf5bTxbtVgsZSBaAtmp545+Fp0IfVB7tH8e/F6l5wqXJfFQ3Bu+VWmoy 34ZMbZ7udXcE4xFraDcEmAJSFJmlqLhJlVtuJI5Hgk+W0vegUohtY3HZoUCWzmYImLEY TtrQwdl1U9ToZPIgwTXwBrGXDHEVEn+eXKnb6lKwJVvawggTf7WINR6NlpVDMGP+QRQe pU+sU5Z2wtXjVwwlVHuBUIloUx0tPOSg0JmcpAj7j5TH4iEcXhiMar/dfyO2VPr+aPBe zqazBBxpK4fmAbICA7um9S/U/UznbHTZ8fPB6R9C8V12GKJiXge7XcZHC4uSO/ohBflx HrEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZQvMoWmr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n29si4304596pgc.517.2022.02.08.23.21.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 23:21:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZQvMoWmr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 14A57E068F6C; Tue, 8 Feb 2022 22:35:09 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391215AbiBGOTa (ORCPT + 99 others); Mon, 7 Feb 2022 09:19:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389764AbiBGNxq (ORCPT ); Mon, 7 Feb 2022 08:53:46 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A2CC043181; Mon, 7 Feb 2022 05:53:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ZCBQfIgsaaqGa9NdTBKby2K4luKCO2x9ltO+P32Dy1E=; b=ZQvMoWmrRru7q2T1QO7Q5DY945 INsEvCnlxHc53LgeQB7iZK2L/tRVPegucijhvHQqRM0tcryCYciDk5ehjRhxBTgklPMWc1M1hwcep J6001389zlRq0WJ1gXvPebIKhQm+OxtecXRCxDHiEZS10LnSSwLo+bjo6Wl58ueAV0Qc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nH4SS-004dvH-6g; Mon, 07 Feb 2022 14:53:32 +0100 Date: Mon, 7 Feb 2022 14:53:32 +0100 From: Andrew Lunn To: Ido Schimmel Cc: Hans Schultz , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Hans Schultz , Roopa Prabhu , Nikolay Aleksandrov , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next 1/4] net: bridge: Add support for bridge port in locked mode Message-ID: References: <20220207100742.15087-1-schultz.hans+netdev@gmail.com> <20220207100742.15087-2-schultz.hans+netdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + if (p->flags & BR_PORT_LOCKED) { > > + fdb_entry = br_fdb_find_rcu(br, eth_hdr(skb)->h_source, vid); > > + if (!(fdb_entry && fdb_entry->dst == p)) > > + goto drop; > > I'm not familiar with 802.1X so I have some questions: Me neither. > > 1. Do we need to differentiate between no FDB entry and an FDB entry > pointing to a different port than we expect? And extending that question, a static vs a dynamic entry? Andrew