Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] PCI: endpoint fix misused goto label
To:     Li Chen <lchen.firstlove@zohomail.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci <linux-pci@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <17e7b9b9ee6.c6d9c6a02564.4545388417402742326@zohomail.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <fbe4db1f-ce55-8329-f1d0-77511e77e2be@ti.com>
Date:   Tue, 8 Feb 2022 12:29:03 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <17e7b9b9ee6.c6d9c6a02564.4545388417402742326@zohomail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21/01/22 1:18 pm, Li Chen wrote:
> From: Li Chen <lchen@ambarella.com>
> 
> If we goto err_map_addr here, buf allocated
> via kmalloc won't get freeed, then memoryleak.
> 
> Signed-off-by: Li Chen <lchen@ambarella.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 96489cfdf58db..60303223976a1 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -441,7 +441,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test)
>  		if (!epf_test->dma_supported) {
>  			dev_err(dev, "Cannot transfer data using DMA\n");
>  			ret = -EINVAL;
> -			goto err_map_addr;
> +			goto err_dma_map;
>  		}
>  
>  		src_phys_addr = dma_map_single(dma_dev, buf, reg->size,
>