Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1622131pxb; Wed, 9 Feb 2022 00:20:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFUdihOP2FBOxdbG8OnKdGH2VFLKdyv0RhmkcYA/qD7AOzHpAtzggm47E2fgkGvRBSfgl7 X-Received: by 2002:a17:907:1c86:: with SMTP id nb6mr895462ejc.547.1644394840815; Wed, 09 Feb 2022 00:20:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644394840; cv=none; d=google.com; s=arc-20160816; b=x0fFUwfqwOvsKFWh6meAqZQSndvAWZ4By0RUpAY+K3/bMGejZ1wJ1eU7lddpCJyZLf NoW/nT89C3Xib32UZpwekxLxCHiowjpHRgPMhcdnlgF2jUPIgk9GTIiKMVX0okF5ncFj K7oNBnNIcjAw/eSpXk+mjzuJTF/Et0vqwXMeDD2rJ27gBuSdIrZrbaOMeRtkxCOp6h39 N718R5fPLU/iEuSivqwHF8syh3WFf8VTFYxnV+WF/XeVkSBeTGeEeJ1Y05kLRngal59c 9rd+qjhY5X1yC0XdcaPRJPCVETpekLOPOjhHRcgxm31KNuiWFA/eQR2wdkKxKOnkk4lX 6VNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=I+9LVnC3lrlCdvXYe57FeSJ6DRNqzHj5SPm/a25omLI=; b=D4ajNcfae0R0+pNtUaFaTh+zi6R55Xo95erfg0bcTEK4q12wjbI3P2wDHKAejSF+c+ eHi38Asg3LyxbHvXUC0b84cPn0X6FDN6Kfokb/pdNWiQpIi/KAbT5948e9ZXk61bV8Rz +OUiZiv+KM+WyYI7qHutiwt5TGk66GmVcEcXjLcMGWi0dAw9UXy2ZP3hz8KEZuHCZsge /mCPSxikexzDSb98gKl4lkcvk+eqs02DJ9tGfgiyvKBeTXrqoDheHPIqaPfGfo1iM4IJ vlaa4fHHjHT9ibHs8zuY0lEmXke/2g1LAGLK9F2teTCf+XdOWuaNk2nblTQNOrRxx6tk Dlfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ht22si10706888ejc.712.2022.02.09.00.20.15; Wed, 09 Feb 2022 00:20:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242013AbiBICkN (ORCPT + 99 others); Tue, 8 Feb 2022 21:40:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243317AbiBIBjs (ORCPT ); Tue, 8 Feb 2022 20:39:48 -0500 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70D05C06157B for ; Tue, 8 Feb 2022 17:39:46 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0V3yNqjc_1644370781; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V3yNqjc_1644370781) by smtp.aliyun-inc.com(127.0.0.1); Wed, 09 Feb 2022 09:39:42 +0800 From: Yang Li To: daniel@ffwll.ch Cc: airlied@linux.ie, Felix.Kuehling@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] drm/amdkfd: Fix NULL but dereferenced coccicheck error Date: Wed, 9 Feb 2022 09:39:40 +0800 Message-Id: <20220209013940.71348-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:2087:27-38: ERROR: bo_buckets is NULL but dereferenced. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 64e3b4e3a712..636391c61caf 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -1982,10 +1982,8 @@ static int criu_checkpoint_bos(struct kfd_process *p, void *mem; bo_buckets = kvzalloc(num_bos * sizeof(*bo_buckets), GFP_KERNEL); - if (!bo_buckets) { - ret = -ENOMEM; - goto exit; - } + if (!bo_buckets) + return -ENOMEM; bo_privs = kvzalloc(num_bos * sizeof(*bo_privs), GFP_KERNEL); if (!bo_privs) { -- 2.20.1.7.g153144c