Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932917AbXBKXdK (ORCPT ); Sun, 11 Feb 2007 18:33:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932920AbXBKXdK (ORCPT ); Sun, 11 Feb 2007 18:33:10 -0500 Received: from nigel.suspend2.net ([203.171.70.205]:34446 "EHLO nigel.suspend2.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932917AbXBKXdI (ORCPT ); Sun, 11 Feb 2007 18:33:08 -0500 Subject: Re: NAK new drivers without proper power management? From: Nigel Cunningham Reply-To: nigel@nigel.suspend2.net To: Manu Abraham Cc: Willy Tarreau , "Rafael J. Wysocki" , Pavel Machek , Arjan van de Ven , LKML , tilman@imap.cc In-Reply-To: <1a297b360702111525v4f26ad4ax9af8fba45936c22f@mail.gmail.com> References: <1171058269.1484.64.camel@nigel.suspend2.net> <1171059433.8675.195.camel@laptopd505.fenrus.org> <20070210193851.GA3956@ucw.cz> <200702102320.39531.rjw@sisk.pl> <1171147026.19894.16.camel@nigel.suspend2.net> <20070211064636.GA12171@1wt.eu> <1171234027.4493.88.camel@nigel.suspend2.net> <1a297b360702111457k3a38eefei485f814f980e58c6@mail.gmail.com> <1171236000.4493.116.camel@nigel.suspend2.net> <1a297b360702111525v4f26ad4ax9af8fba45936c22f@mail.gmail.com> Content-Type: text/plain Date: Mon, 12 Feb 2007 10:33:06 +1100 Message-Id: <1171236787.4493.132.camel@nigel.suspend2.net> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 37 Hi. On Mon, 2007-02-12 at 03:25 +0400, Manu Abraham wrote: > On 2/12/07, Nigel Cunningham wrote: > > Hi. > > > > On Mon, 2007-02-12 at 02:57 +0400, Manu Abraham wrote: > > > On 2/12/07, Nigel Cunningham wrote: > > > > > > > Neither am I. I'm just asking that new drivers have power management as > > > > standard. > > > > > What if the hardware doesn't support power management ? > > > > You would still want to do the cleanup and configuration that you'd do > > for module load/unload. > > > By adding dummy functions, wouldn't that just look awkward ? If all you need to do is say 'I don't need to do anything' and we have a shared function that does that, all we're talking about doing is adding to your struct pci_device (or whatever) .resume = generic_empty_resume; To me at least, that doesn't look awkward, and says cleanly and clearly that you've checked things over and decided you know what's required. Regards, Nigel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/