Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7753c65a-ce16-eb4f-395b-bc5e54c647c6@infradead.org>
Date:   Mon, 7 Feb 2022 10:47:21 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description
Content-Language: en-US
To:     =?UTF-8?Q?Mateusz_Jo=c5=84czyk?= <mat.jonczyk@o2.pl>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-hwmon@vger.kernel.org
Cc:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>
References: <20220207182940.242838-1-mat.jonczyk@o2.pl>
 <20220207182940.242838-2-mat.jonczyk@o2.pl>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220207182940.242838-2-mat.jonczyk@o2.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi--

On 2/7/22 10:29, Mateusz Jończyk wrote:
> It is not the laptops, but the /proc/i8k interface that is legacy. The
> old description was confusing, fix this.
> 
> I'm not a native English speaker, so I'd like that someone proofread
> this description.
> 
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> Cc: Pali Rohár <pali@kernel.org>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> ---
>  drivers/hwmon/Kconfig | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index dd244aa747ad..8f9f41a9ef70 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -506,18 +506,17 @@ config SENSORS_DELL_SMM
>  	  userspace interface for i8kutils package.
>  
>  config I8K
> -	bool "Dell i8k legacy laptop support"
> +	bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver"
>  	depends on SENSORS_DELL_SMM
>  	help
> -	  This option enables legacy /proc/i8k userspace interface in hwmon
> -	  dell-smm-hwmon driver. Character file /proc/i8k reports bios version,
> -	  temperature and allows controlling fan speeds of Dell laptops via
> -	  System Management Mode. For old Dell laptops (like Dell Inspiron 8000)
> -	  it reports also power and hotkey status. For fan speed control is
> -	  needed userspace package i8kutils.
> +	  This option enables the legacy /proc/i8k userspace interface of the
> +	  dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS
> +	  version, temperatures and allows control of fan speeds of some Dell
> +	  laptops. Sometimes, it reports also power and hotkey status.

	  Comma not needed ^^^; "it also reports ..." would be more common.

>  
> -	  Say Y if you intend to run this kernel on old Dell laptops or want to
> -	  use userspace package i8kutils.
> +	  This interface is required to run programs from the i8kutils package.
> +
> +	  Say Y if you intend to run userspace programs that use this interface.
>  	  Say N otherwise.
>  
>  config SENSORS_DA9052_ADC

thanks.

-- 
~Randy