Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [BUG] usb: typec: ucsi: possible deadlock in ucsi_pr_swap() and
 ucsi_handle_connector_change()
To:     heikki.krogerus@linux.intel.com,
        Greg KH <gregkh@linuxfoundation.org>, kyletso@google.com,
        jackp@codeaurora.org, andy.shevchenko@gmail.com,
        unixbhaskar@gmail.com, subbaram@codeaurora.org,
        mrana@codeaurora.org
Cc:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <037de7ac-e210-bdf5-ec7a-8c0c88a0be20@gmail.com>
Date:   Wed, 9 Feb 2022 11:50:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hello,

My static analysis tool reports a possible deadlock in the ucsi driver 
in Linux 5.16:

ucsi_pr_swap()
   mutex_lock(&con->lock); --> Line 962 (Lock A)
   wait_for_completion_timeout(&con->complete, ...) --> Line 981 (Wait X)

ucsi_handle_connector_change()
   mutex_lock(&con->lock); --> Line 763 (Lock A)
   complete(&con->complete); --> Line 782 (Wake X)
   complete(&con->complete); --> Line 807 (Wake X)

When ucsi_pr_swap() is executed, "Wait X" is performed by holding "Lock 
A". If ucsi_handle_connector_change() is executed at this time, "Wake X" 
cannot be performed to wake up "Wait X" in 
ucsi_handle_connector_change(), because "Lock A" has been already held 
by ucsi_handle_connector_change(), causing a possible deadlock.
I find that "Wait X" is performed with a timeout, to relieve the 
possible deadlock; but I think this timeout can cause inefficient execution.

I am not quite sure whether this possible problem is real.
Any feedback would be appreciated, thanks :)


Best wishes,
Jia-Ju Bai